Merge lp:~dholbach/harvest/980657 into lp:harvest

[Daniel Holbach]

only return valid opportunities

[Daniel Holbach (dholbach)]

Can anyone help with reviewing these? :)

[Dylan McCall (dylanmccall)]

Is there a way to do this that doesn't use the object_name property? It bothers me a tiny bit because it's undocumented.

Not a big deal, though. It does do the job :)

[Daniel Holbach (dholbach)]

Hm, I tried around a bit, but couldn't find a better way to do it. Do you have a suggestion?

[Dylan McCall (dylanmccall)]

Yeah, I couldn't find anything either. Looks like this is fairly common, so I doubt Django will surprise us here.

review: Approve

=== modified file 'harvest/services/__init__.py'
--- harvest/services/__init__.py	2012-04-11 16:47:39 +0000
+++ harvest/services/__init__.py	2012-04-13 10:47:20 +0000
@@ -75,6 +75,8 @@
     if exclude is not None:
         search_fields = [f for f in search_fields if f not in exclude]
     search_values = dict([(str(key), value) for (key, value) in request.items()])
+    if model._meta.object_name == 'Opportunity':
+        search_values['valid'] = True
 
     extra_arguments = {}
     for key in search_values.keys():