Canonical Click Reviewers tools (obsolete)

Merge lp:~dholbach/click-reviewers-tools/deb-vs-click into lp:click-reviewers-tools

  1. deb-vs-click
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Approved by: Daniel Holbach
Approved revision: 201
Merged at revision: 212
Proposed branch: lp:~dholbach/click-reviewers-tools/deb-vs-click
Merge into: lp:click-reviewers-tools
Diff against target: 13 lines (+3/-0)
1 file modified
clickreviews/cr_common.py (+3/-0)
To merge this branch: bzr merge lp:~dholbach/click-reviewers-tools/deb-vs-click
Reviewer Review Type Date Requested Status
Martin Albisetti (community) Approve
Review via email: mp+224297@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Martin Albisetti (beuno) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clickreviews/cr_common.py'
2--- clickreviews/cr_common.py 2014-04-29 14:20:39 +0000
3+++ clickreviews/cr_common.py 2014-06-24 13:52:05 +0000
4@@ -60,6 +60,9 @@
5 self.click_package = fn
6 self._check_path_exists()
7 if not self.click_package.endswith(".click"):
8+ if self.click_package.endswith(".deb"):
9+ error("filename does not end with '.click', but '.deb' "
10+ "instead. See http://askubuntu.com/a/485544/94326 for how click packages are different.")
11 error("filename does not end with '.click'")
12
13 self.review_type = review_type

Subscribers

People subscribed via source and target branches