Canonical Click Reviewers tools (obsolete)

Merge lp:~dholbach/click-reviewers-tools/clearer-error-message into lp:click-reviewers-tools

  1. clearer-error-message
  2. Merge into trunk
Proposed by Daniel Holbach
Status: Merged
Approved by: Jamie Strandboge
Approved revision: 247
Merged at revision: 248
Proposed branch: lp:~dholbach/click-reviewers-tools/clearer-error-message
Merge into: lp:click-reviewers-tools
Diff against target: 14 lines (+6/-1)
1 file modified
clickreviews/modules.py (+6/-1)
To merge this branch: bzr merge lp:~dholbach/click-reviewers-tools/clearer-error-message
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Approve
Canonical Store Reviewers Pending
Review via email: mp+236343@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

Looks good. Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clickreviews/modules.py'
2--- clickreviews/modules.py 2014-09-02 16:32:51 +0000
3+++ clickreviews/modules.py 2014-09-29 14:06:25 +0000
4@@ -68,4 +68,9 @@
5 init_object = find_main_class(module_name)
6 if not init_object:
7 return None
8- return init_object(click_file)
9+ try:
10+ ob = init_object(click_file)
11+ except TypeError as e:
12+ print('Could not init %s: %s' % (init_object, str(e)))
13+ return None
14+ return ob

Subscribers

People subscribed via source and target branches