Merge lp:~dholbach/click-reviewers-tools/1355215 into lp:click-reviewers-tools
Status: | Merged |
---|---|
Merged at revision: | 225 |
Proposed branch: | lp:~dholbach/click-reviewers-tools/1355215 |
Merge into: | lp:click-reviewers-tools |
Diff against target: |
163 lines (+135/-2) 3 files modified
bin/click-review (+130/-0) debian/changelog (+4/-1) run-pep8 (+1/-1) |
To merge this branch: | bzr merge lp:~dholbach/click-reviewers-tools/1355215 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Martin Albisetti (community) | Approve | ||
Review via email:
|
Description of the change
daniel@
Errors
------
- lint_control_
Click-Version is too old, has '0.3', needs '0.4' or newer
http://
- lint_package_
'armhf' != 'all' from DEBIAN/control
Warnings
--------
- lint_framework
'ubuntu-sdk-13.10' is deprecated. Please use a newer framework
http://
- functional_
Found files that use unsupported QtWebKit (should use UbuntuWebview (Ubuntu.
http://
daniel@
daniel@
Passed!
daniel@
Works nicely, thanks.
alan@deep- thought: /tmp/1355215β« bin/click-review ~/Downloads/ com.ubuntu. music_1. 3.586_all. click hub_valid_ music_source template_ valid (apparmor.json) local_extension s
Errors
------
- content_
'source' is empty
- security_
(MANUAL REVIEW) 'unconfined' not allowed
Warnings
--------
- lint_click_
found unofficial extensions: x-source, x-test