Merge lp:~dhavlicek/awn-extras/calendar-evolution into lp:awn-extras

[Dave Havlicek]

[Michael Rooney (mrooney)]

Looks pretty good on an initial review. One comment is that you shouldn't be doing print statements for normal things like on line 50 (printing errors are fine).

I also liked your change in the previous branch where you used the calendar module to get the length of the month; I wouldn't mind seeing that in there as well as a bonus cleanup.

review: Needs Fixing

[lp:~dhavlicek/awn-extras/calendar-evolution]

1006. By Dave Havlicek on 2009-01-30

removing debug print statement that i forgot about - also fixing days_in_month method in calthread.py

[Mark Lee (malept)]

It seems that we're adding a dependency on Evolution's python bindings. This means changes in configure.ac (and probably debian/control as well).

review: Needs Fixing (superreview)

[Michael Rooney (mrooney)]

"Looks pretty good on an initial review. One comment is that you shouldn't be doing print statements for normal things like on line 50 (printing errors are fine).

I also liked your change in the previous branch where you used the calendar module to get the length of the month; I wouldn't mind seeing that in there as well as a bonus cleanup."

Also on 92 please "except Exception:" instead. Otherwise you are also going to catch KeyboardInterrupt and SystemExit events which are thrown as exceptions. This is something you want to do almost everywhere in Python, although it is even better to explicitly catch a particular exception if you know you your except code is handling specifically say an IOError. I would recommend http://www.python.org/dev/peps/pep-0352/ as a good read, at least the transition plan section :)

[lp:~dhavlicek/awn-extras/calendar-evolution]

1007. By Dave Havlicek on 2009-01-30

evocal.py - catch only specific "Exception" to avoid catching KeyboardInterrupt and SystemExit

[Mark Lee (malept)]

> I also liked your change in the previous branch where you used the calendar
> module to get the length of the month; I wouldn't mind seeing that in there as
> well as a bonus cleanup.

Seems that there's a slight typo with this implementation. I've fixed it and this particular change is now in trunk revision 1149.

[Mark Lee (malept)]

> It seems that we're adding a dependency on Evolution's python bindings. This
> means changes in configure.ac (and probably debian/control as well).

I suppose we could sidestep this somewhat by using awn.check_dependencies() for the evolution module, and disabling evolution support if it doesn't exist.

Unmerged revisions

1007. By Dave Havlicek on 2009-01-30

evocal.py - catch only specific "Exception" to avoid catching KeyboardInterrupt and SystemExit

1006. By Dave Havlicek on 2009-01-30

removing debug print statement that i forgot about - also fixing days_in_month method in calthread.py

1005. By Dave Havlicek on 2009-01-30

evocal.py now supports recurring events and web calendars