Merge lp:~devcamcar/django-nova/fix_volume_maintenance into lp:django-nova

Proposed by Devin Carlen
Status: Merged
Approved by: Devin Carlen
Approved revision: 10
Merged at revision: 10
Proposed branch: lp:~devcamcar/django-nova/fix_volume_maintenance
Merge into: lp:django-nova
Diff against target: 56 lines (+7/-7)
1 file modified
src/django_nova/views/volumes.py (+7/-7)
To merge this branch: bzr merge lp:~devcamcar/django-nova/fix_volume_maintenance
Reviewer Review Type Date Requested Status
Devin Carlen Approve
Review via email: mp+47477@code.launchpad.net

Description of the change

Made volume views use the handle_nova_error decorator.

To post a comment you must log in.
Revision history for this message
Devin Carlen (devcamcar) wrote :

approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'src/django_nova/views/volumes.py'
--- src/django_nova/views/volumes.py 2011-01-18 23:07:26 +0000
+++ src/django_nova/views/volumes.py 2011-01-25 23:18:44 +0000
@@ -24,14 +24,14 @@
24from django.contrib import messages24from django.contrib import messages
25from django.contrib.auth.decorators import login_required25from django.contrib.auth.decorators import login_required
26from django.shortcuts import redirect, render_to_response26from django.shortcuts import redirect, render_to_response
27from django.views.decorators.cache import never_cache
28from django_nova import exceptions27from django_nova import exceptions
29from django_nova import forms28from django_nova import forms
30from django_nova.shortcuts import get_project_or_404, get_projects29from django_nova.exceptions import handle_nova_error
30from django_nova.shortcuts import get_project_or_404
3131
3232
33@login_required33@login_required
34@never_cache34@handle_nova_error
35def index(request, project_id):35def index(request, project_id):
36 project = get_project_or_404(request, project_id)36 project = get_project_or_404(request, project_id)
37 volumes = project.get_volumes()37 volumes = project.get_volumes()
@@ -46,7 +46,7 @@
4646
4747
48@login_required48@login_required
49@never_cache49@handle_nova_error
50def add(request, project_id):50def add(request, project_id):
51 project = get_project_or_404(request, project_id)51 project = get_project_or_404(request, project_id)
5252
@@ -79,7 +79,7 @@
7979
8080
81@login_required81@login_required
82@never_cache82@handle_nova_error
83def delete(request, project_id, volume_id):83def delete(request, project_id, volume_id):
84 project = get_project_or_404(request, project_id)84 project = get_project_or_404(request, project_id)
8585
@@ -98,7 +98,7 @@
9898
9999
100@login_required100@login_required
101@never_cache101@handle_nova_error
102def attach(request, project_id):102def attach(request, project_id):
103 project = get_project_or_404(request, project_id)103 project = get_project_or_404(request, project_id)
104104
@@ -133,7 +133,7 @@
133133
134134
135@login_required135@login_required
136@never_cache136@handle_nova_error
137def detach(request, project_id, volume_id):137def detach(request, project_id, volume_id):
138 project = get_project_or_404(request, project_id)138 project = get_project_or_404(request, project_id)
139139

Subscribers

People subscribed via source and target branches

to all changes:
to status/vote changes: