Code review comment for lp:~desrt/indicator-appmenu/hud-rewrite-wip

Revision history for this message
Charles Kerr (charlesk) wrote :

* About the text conflict, we could use <glib/gi18n.h> instead of locale.h and libintl.h

* In hud_indicator_source_name_vanished(), I think you meant to invoke hud_source_unuse()?

* I think the answer is probably no, but wanted to ask if hud_window_source's dispose or finalize need to do anything about active_collector or its "changed" signal that hud_window_source connected to.

« Back to merge proposal