Code review comment for lp:~desrt/indicator-appmenu/hud-performance

Revision history for this message
Ted Gould (ted) wrote :

A couple of non-critical comments:

* Next time please use move for things like the schemas as then diffs are tracked on them which makes reviewing them much easier.

* I think the "magic 32" should probably be a #define just so that if someone changes it it will be changed everywhere. For instance, changing it in _new() could cause an assert failure further down the road.

* A comment on hud_token_list_distance_slow () on why the assert isn't insane would be good :-)

* Love the test :-)

review: Approve

« Back to merge proposal