Code review comment for lp:~deryck/launchpad/upstream-empty-display-707825

Revision history for this message
Abel Deuring (adeuring) wrote :

nice branch! Just a minor remark:

@@ -65,7 +68,8 @@
     </tr>
     <tr
       tal:attributes="id string:${submission/origin_html_id};
- class string:discreet secondary ${dismissable}">
+ class string:discreet secondary ${dismissable}"
+ tal:condition="submission/suggestion_text">

I'd prefer to have "tal:condition" before "tal:attributes". While the ZPT machinery does not care about the order of tag attributes, I find it easier to read the tal: attributes in ZPT's execution order.

review: Approve (code)

« Back to merge proposal