Merge lp:~deryck/launchpad/show-package-hot-bugs-455995 into lp:launchpad

Proposed by Deryck Hodge
Status: Merged
Approved by: Deryck Hodge
Approved revision: not available
Merged at revision: not available
Proposed branch: lp:~deryck/launchpad/show-package-hot-bugs-455995
Merge into: lp:launchpad
Diff against target: 31 lines (+10/-1)
1 file modified
lib/lp/bugs/templates/bugtarget-bugs.pt (+10/-1)
To merge this branch: bzr merge lp:~deryck/launchpad/show-package-hot-bugs-455995
Reviewer Review Type Date Requested Status
Eleanor Berger (community) Approve
Review via email: mp+17675@code.launchpad.net

Commit message

Show package name in hot bugs list for distributions.

To post a comment you must log in.
Revision history for this message
Deryck Hodge (deryck) wrote :

This branch fixes bug 455995, which notes that a hot bugs list for a
distro bugs home page doesn't show the package name. The fix for this
is to test that we should be showing the column using
view.columns_to_show and add the column if so.

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/templates/bugtarget-bugs.pt

Revision history for this message
Eleanor Berger (intellectronica) wrote :

lovely!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
--- lib/lp/bugs/templates/bugtarget-bugs.pt 2009-12-19 19:12:34 +0000
+++ lib/lp/bugs/templates/bugtarget-bugs.pt 2010-01-19 18:15:24 +0000
@@ -103,10 +103,16 @@
103103
104 <h2 style="margin-top: 1em">Hot bugs</h2>104 <h2 style="margin-top: 1em">Hot bugs</h2>
105105
106 <table class="listing" id="hot-bugs">106 <table class="listing" id="hot-bugs"
107 tal:define="show_package python: 'packagename' in view.columns_to_show
108 ">
107 <thead>109 <thead>
108 <tr>110 <tr>
109 <th colspan="3">Summary</th>111 <th colspan="3">Summary</th>
112 <th
113 tal:condition="show_package">
114 Package
115 </th>
110 <th>Status</th>116 <th>Status</th>
111 <th>Importance</th>117 <th>Importance</th>
112 <th>Last changed</th>118 <th>Last changed</th>
@@ -124,6 +130,9 @@
124 <a tal:attributes="href bugtask/fmt:url"130 <a tal:attributes="href bugtask/fmt:url"
125 tal:content="bugtask/bug/title" />131 tal:content="bugtask/bug/title" />
126 </td>132 </td>
133 <td tal:content="structure bugtask/sourcepackagename/name|default"
134 tal:condition="show_package"
135 >&mdash;</td>
127 <td tal:attributes="class string:status${bugtask/status/name}"136 <td tal:attributes="class string:status${bugtask/status/name}"
128 tal:content="bugtask/status/title" />137 tal:content="bugtask/status/title" />
129 <td tal:attributes="138 <td tal:attributes="