Code review comment for lp:~deryck/launchpad/pop-up-help-positioning-574682

Revision history for this message
Deryck Hodge (deryck) wrote :

Hi, Tom.

Thanks for the review.

I looked into converting to lazr-js myself, but I didn't have time to invest when a simple fix will work. There are still other, deeper dependencies on MochiKit than this bit of code, so it didn't seem worth it to me for now. I don't think it's worth a Windmill test, either, to be honest.

I did remove the if statement. I thought it was a bit more clear why this was needed with the if statement, but no harm without either, so I dropped it.

Thanks again for the review today.

Cheers,
deryck

« Back to merge proposal