On Fri, Aug 14, 2009 at 9:30 AM, Guilherme Salgado<email address hidden> wrote:
> I noticed the link to the bug's page on the heading doesn't exist in the
> new UI, but I don't think that's a problem as we now have the 'Cancel'
> link at the bottom. It'd be nice if you could double check that with
> Martin.
I think this is okay because the breadcrumbs Gavin is working on will
have the bug link.
>> + @property
>> + def label(self):
>> + """The form label."""
>> + return 'Edit Bug Information'
>
> I guess we don't need this to be a property, do we?
>
I'm not sure I follow exactly what you mean, sorry. Do you mean I
should use the simpler form of:
label = 'Edit Bug Description'
That would make since given the string is not constructed from some
other piece of data. But I wanted to make sure I understood you
first.
Hi, salgado. Thanks for the review!
On Fri, Aug 14, 2009 at 9:30 AM, Guilherme Salgado<email address hidden> wrote:
> I noticed the link to the bug's page on the heading doesn't exist in the
> new UI, but I don't think that's a problem as we now have the 'Cancel'
> link at the bottom. It'd be nice if you could double check that with
> Martin.
I think this is okay because the breadcrumbs Gavin is working on will
have the bug link.
>> + @property
>> + def label(self):
>> + """The form label."""
>> + return 'Edit Bug Information'
>
> I guess we don't need this to be a property, do we?
>
I'm not sure I follow exactly what you mean, sorry. Do you mean I
should use the simpler form of:
label = 'Edit Bug Description'
That would make since given the string is not constructed from some
other piece of data. But I wanted to make sure I understood you
first.
Cheers,
deryck