On Wed, Aug 19, 2009 at 9:17 AM, Gavin
Panella<email address hidden> wrote:
> Looks good. The layout of the page:
>
> <h2>Bug #11 in Jokosher: "Make Jokosher use autoaudiosink"</h2>
> <h1>Add a comment or attachment to Bug #11</h1>
>
> is better than, IMO, the layout I did for the bug activity log:
I've updated my branch with your patch to match. Glad you mentioned
that. As I understand it from Curtis, this is the form we should use
for most all the pages, only overriding the heading slot for an
object's index page.
> Other than that, only one tiny comment :)
The "Bug #XXX" capitalization has been updated as well. :)
Hi, Gavin.
Thanks for the review!
On Wed, Aug 19, 2009 at 9:17 AM, Gavin
Panella<email address hidden> wrote:
> Looks good. The layout of the page:
>
> <h2>Bug #11 in Jokosher: "Make Jokosher use autoaudiosink"</h2>
> <h1>Add a comment or attachment to Bug #11</h1>
>
> is better than, IMO, the layout I did for the bug activity log:
I've updated my branch with your patch to match. Glad you mentioned
that. As I understand it from Curtis, this is the form we should use
for most all the pages, only overriding the heading slot for an
object's index page.
> Other than that, only one tiny comment :)
The "Bug #XXX" capitalization has been updated as well. :)
Cheers,
deryck