could you add TestCases for the celebrities bug_watch_updater,
bug_importer, janitor?
> +class TestBugTaskStatusTransitionForPrivilegedUserBase:
> + """Base class used to test privileged users and status transitions."""
> +
> + layer = LaunchpadFunctionalLayer
> +
> + def setUp(self):
> + super(TestBugTaskStatusTransitionForPrivilegedUserBase, self).setUp()
> + # Creation of task and target are deferred to subclasses.
> + self.task = None
> + self.person = None
> + self.makePersonAndTask()
> +
> + def makePersonAndTask(self):
> + """Create a bug task and privileged person for this task.
> +
> + This method is user by subclasses to correctly setup
> + each test.
> + """
I think this should be something like "is (overloaded|implemented) by
subclasses"
Hi Deryck,
thanks for the refactoring. r=me.
Just a few nitpicks:
could you add TestCases for the celebrities bug_watch_updater,
bug_importer, janitor?
> +class TestBugTaskStat usTransitionFor PrivilegedUserB ase: onalLayer skStatusTransit ionForPrivilege dUserBase, self).setUp() AndTask( ) sk(self) :
> + """Base class used to test privileged users and status transitions."""
> +
> + layer = LaunchpadFuncti
> +
> + def setUp(self):
> + super(TestBugTa
> + # Creation of task and target are deferred to subclasses.
> + self.task = None
> + self.person = None
> + self.makePerson
> +
> + def makePersonAndTa
> + """Create a bug task and privileged person for this task.
> +
> + This method is user by subclasses to correctly setup
> + each test.
> + """
I think this should be something like "is (overloaded| implemented) by
subclasses"
cheers
Abel