Code review comment for lp:~dernils/duplicity/Dockerfile

Revision history for this message
Kenneth Loafman (kenneth-loafman) wrote :

A couple of changes we need to make:

1) Your docker image does not match the released Dockerfile. No user, and
in the wrong directory.
2) We need to have an override for the 10.10/16 subnet. It conflicts with
one of mine, so it'll probably hit someone else. A simple define at the
top of the setup would do for now.
3) Looking good! I'll see about getting a duplicity user on Docker Hub.

On Sun, May 14, 2017 at 10:35 AM, <email address hidden> wrote:

> The proposal to merge lp:~dernils/duplicity/Dockerfile into lp:duplicity
> has been updated.
>
> Status: Needs review => Merged
>
> For more details, see:
> https://code.launchpad.net/~dernils/duplicity/Dockerfile/+merge/324027
> --
> Your team duplicity-team is requested to review the proposed merge of
> lp:~dernils/duplicity/Dockerfile into lp:duplicity.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~duplicity-team
> Post to : <email address hidden>
> Unsubscribe : https://launchpad.net/~duplicity-team
> More help : https://help.launchpad.net/ListHelp
>

« Back to merge proposal