Code review comment for lp:~denys.duchier/bzr/bzr.ssl

Revision history for this message
John A Meinel (jameinel) wrote :

So, IIRC, my personal concern was that we shouldn't re-use the same port for bzr:// and bzrs:// access. (Note that we could use bzr+ssl:// but that is going to be *very* close to bzr+ssh://...)

If we want to re-use the port, then we should be supporting STARTTLS, otherwise we should use 2 ports.

I realize this isn't strictly required, but it seems to be a fairly standard way of handling ssl versus non-ssl access. (Consider http vs https, imap vs imaps)

Robert is the URL guru, though. So if he feels strongly that this is ok, then we can probably just do it.

review: Needs Information

« Back to merge proposal