Code review comment for lp:~deeptik/linaro-license-protection/publish-to-snapshot

Thanks paul for comments. I will reply back on tuesday when am back to office.

Thanks!!!
Deepti

On 3/9/12, Paul Sokolovsky <email address hidden> wrote:
> 111 +def main():
> 112 + uploads_path = '/srv3/snapshots.linaro.org/uploads/'
> 113 + target_path = '/srv3/snapshots.linaro.org/www/'
> 114 + uploads_path = '/tmp/uploads/'
> 115 + target_path = '/tmp/www/'
>
> IMHO, it would be better to treat these as the constants, not as the
> variables, to be defined in the beginning of the script (like they were
> before r50).
>
> --
> https://code.launchpad.net/~deeptik/linaro-license-protection/publish-to-snapshot/+merge/96735
> You are the owner of
> lp:~deeptik/linaro-license-protection/publish-to-snapshot.
>

--
Sent from my mobile device

Thanks and Regards,
Deepti
Infrastructure Team Member, Linaro Platform Teams
Linaro.org | Open source software for ARM SoCs
Follow Linaro: http://www.facebook.com/pages/Linaro
http://twitter.com/#!/linaroorg - http://www.linaro.org/linaro-blog