Code review comment for lp:~deeptik/linaro-license-protection/publish-to-snapshot

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

79 + try:
80 + # Make a note of the contents of src dir so that
81 + # it can be used to validate the move to destination
82 + uploads_dirList = os.listdir(build_dir_path)

That sounds complicated and overinsuring. Can't we make requirement that upload dir and destination dir were on the same FS, so we can just use mv? Even if we can't, why wouldn't we trust shutil.copy2()? It either does the copy, or throws an exception, so we can't miss failed move.

Minor note - would be nice to use consistent var naming convention, like uploads_dir_list.

« Back to merge proposal