Code review comment for lp:~deeptik/linaro-license-protection/publish-to-snapshot

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

9
parser.add_argument("-a", "--archive_info", dest="archive_info",
10
                    help="Specify the job which resulted the archive to be stored.\
11
                         Ex: ${JOB_NAME}/${BUILD_NUMBER} should be specified for \
12
                             andriod and for \
13
                             kernel-hwpack ${KERNEL_NAME}/${KERNEL_JOB_NAME}")

This seems like confusing option. Reading the help, I don't have an idea why it is called "archive_info". Nor reading help I have clear picture what and how it should be used/works - that's too much specifics, out of context. This script is supposed to be called from Jenkins, and Jenkins cab basically pass to it it job name (in its native format) and build number. That's what script should accept, and help for options should describe just that, any specifics like the fact that job name have internal structure based on --job-type should be left to manual IMHO.

review: Needs Fixing

« Back to merge proposal