Code review comment for lp:~deeptik/linaro-license-protection/publish-to-snapshot

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

One immediate comment is inconsistent format of the long options, like "--job_type". It's GNU (originators of long options) convention that long options use dashes as separators. It's of course also looks better and easier to remember. We had/have the same issue with l-m-c: there was non-compliant options, then there was a patch to fix it, then it turned out it breaks existing scripts which pass those options, then the fix had to be reverted or something, etc. So, we should do it rightly from the start.

review: Needs Fixing

« Back to merge proposal