Merge lp:~deeptik/linaro-ci/fix-bug1013611 into lp:linaro-ci
Proposed by
Deepti B. Kalakeri
Status: | Merged |
---|---|
Approved by: | Milo Casagrande |
Approved revision: | 73 |
Merged at revision: | 72 |
Proposed branch: | lp:~deeptik/linaro-ci/fix-bug1013611 |
Merge into: | lp:linaro-ci |
Diff against target: |
222 lines (+192/-0) 6 files modified
node/init-fifo (+19/-0) node/setup-natty-node (+23/-0) node/setup-oneiric-node (+32/-0) node/setup-precise-node (+38/-0) node/setup_lib (+59/-0) node/userdata-fifo (+21/-0) |
To merge this branch: | bzr merge lp:~deeptik/linaro-ci/fix-bug1013611 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Paul Sokolovsky | Approve | ||
Milo Casagrande (community) | Approve | ||
Review via email: mp+110740@code.launchpad.net |
To post a comment you must log in.
Hello Deepti,
thanks for working on this!
Merge proposal looks good to me, the only thing I will add is or a README file with a little bit of docs/description of the various scripts, or small comments per script that describe the script intents (even if they are not that complex, at least it will be easier for other to pick up faster what has been done).
Also, I see that two files have license headers, others do not: what is the policy in these cases? Should all source code files have a license header?
Another thing, but definitely minor: files use underscores or dashes in their names. There are file names with the latter and other with the former. Should we use just one?