Code review comment for lp:~deeptik/lava-test/tiobench

Revision history for this message
Paul Larson (pwlars) wrote :

Found the problem, you're regexp for the 2nd match line is too strict. Given that there's nothing else I see in the subsequent output that could get a false positive for it, I'd consider just having it match \d+\.\d+\.\d+\S+

2.6.35-1006-linaro-omap 512 4096 2 8.87 20.57% 1.747 1698.33 0.00000 0.00000 43

62 + test_id = ('%s_%s[kernel]_%s[filesize]_%s[blksize]') \
63 + % (test_case_id, kernel, filesize, blks_size)
I don't think I'd include the kernel in the test_case_id. The other parts of it are fine though I think.

64 + results['test_case_id'] = test_id
Let's match to a variable name other than test_case_id earlier on so that we don't have to do this.

Your test_case_id's currently come out looking something like this:
"SequentialReads_2.6.35-1006-linaro-omap[kernel]_512[filesize]_4096[blksize]"
This contains illegal characters, notably the []'s. The test_case_id pattern that it compares against for determining legality is:
"^([a-zA-Z0-9_-]+)(\.[a-zA-Z0-9_-]+)*$"

« Back to merge proposal