Code review comment for lp:~deeptik/lava-test/tiobench

On Tue, 2010-10-05 at 17:44 +0000, Deepti B. Kalakeri wrote:
> > 37 + "./tiobench.pl --block=4096 --block=8192 --threads=10 "\
> > 38 + " --size=%s --numruns=2" % (VERSION, FILE_SIZE)]
> > Is there a reason why --block is specified twice?
> > Also, we need to scale this WAAAAAY back. Most of the devices we use are
>
> I did not get with point "we need to scale this WAAAAAY back." Can you elaborate.?
>
> > booted off a small SD card, so space is very limited. Also, 10 threads on a
> > single-core, low power device is about 8 or 9 too many.
>
> This is just an example of how the tiobench can be used. I basically written the tiobench to use the (disk) block size of 4096 and then 8192.
> So in case if Linaro how much block size should be used ?
ok, I see from reading the help that it seems you can specify --block
more than once with multiple runs and it will do both. I was thinking
maybe one of them was accidental. I don't have a problem with the block
size if you feel it is appropriate. As mentioned before, the two things
that seem to be causing problems here are the number of threads, and the
--size. As a point of reference, I have about 200M free on my sd card,
but there's no guarantee that every machine will. I don't know that
there's an easy way to tell it not to try to overconsume space, if not
then we just have to make a reasonable guess. I would not go over 2
threads.