MAAS

Merge ~deadlight/maas:1773133-dhcp-truncated-tooltip into maas:master

  1. Git
  2. lp:~deadlight/maas
  3. 1773133-dhcp-truncated-tooltip
  4. Merge into master
Proposed by Karl Williams
Status: Merged
Approved by: Karl Williams
Approved revision: de6b005f63730fb62f64cc0bed973f331db2b236
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~deadlight/maas:1773133-dhcp-truncated-tooltip
Merge into: maas:master
Diff against target: 13 lines (+1/-1)
1 file modified
src/maasserver/static/partials/settings.html (+1/-1)
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
MAAS Lander Approve
MAAS Maintainers Pending
Review via email: mp+348386@code.launchpad.net

Commit message

LP: #1773133 - Allow tooltip to overflow package repo 'enabled' cell

Description of the change

The tooltip in the settings->package repos table (the 'enabled' field) was being cut off by the cell's lack of overflow. Applied a class to allow overflow for that cell.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b 1773133-dhcp-truncated-tooltip lp:~deadlight/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: de6b005f63730fb62f64cc0bed973f331db2b236

review: Approve
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/settings.html b/src/maasserver/static/partials/settings.html
2index eb34f9e..7f9f233 100644
3--- a/src/maasserver/static/partials/settings.html
4+++ b/src/maasserver/static/partials/settings.html
5@@ -372,7 +372,7 @@
6 </span>
7 </td>
8 <td class="col-4" aria-label="URL" data-ng-if="editRepository !== repository">{$ repository.url $}</td>
9- <td class="col-2" aria-label="Enabled" data-ng-if="editRepository !== repository">
10+ <td class="col-2 p-table--action-cell" aria-label="Enabled" data-ng-if="editRepository !== repository">
11 <div class="onoffswitch" data-ng-if="!isMirror(repository)">
12 <input type="checkbox" name="enabled" class="onoffswitch-checkbox" id="enabled-repo-{$ repository.id $}"
13 data-ng-model="repository.enabled"

Subscribers

People subscribed via source and target branches