MAAS

Merge ~deadlight/maas:contextual-overflow into maas:master

  1. Git
  2. lp:~deadlight/maas
  3. contextual-overflow
  4. Merge into master
Proposed by Karl Williams
Status: Merged
Approved by: Anthony Dillon
Approved revision: cd9ea95e7613f0f723071f397b002c7274b7c5ac
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~deadlight/maas:contextual-overflow
Merge into: maas:master
Diff against target: 17 lines (+2/-2)
1 file modified
src/maasserver/static/partials/domain-details.html (+2/-2)
Reviewer Review Type Date Requested Status
Anthony Dillon Approve
MAAS Lander Approve
MAAS Maintainers Pending
Review via email: mp+344219@code.launchpad.net

Commit message

LP: #1766781 - Fix for contextual menu overflow issues

Description of the change

Fix for contextual menu overflow issues on DNS records

QA:
 - Trigger the contextual menu for a resource record on the DNS page (add a new one if none are editable)
 - See that the menu now overflows the container properly

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b contextual-overflow lp:~deadlight/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 468cc7f2fcca8bd0db5edb38d3dc8c45fdef77d8

review: Approve
Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

One small extra improvement please.

review: Needs Fixing
~deadlight/maas:contextual-overflow updated
cd9ea95... by Karl Williams

Make domain details acton buttons small

Revision history for this message
Anthony Dillon (ya-bo-ng) wrote :

Thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/static/partials/domain-details.html b/src/maasserver/static/partials/domain-details.html
2index 039ab74..1502f54 100644
3--- a/src/maasserver/static/partials/domain-details.html
4+++ b/src/maasserver/static/partials/domain-details.html
5@@ -234,10 +234,10 @@
6 <td class="col-2" aria-label="TTL" data-ng-if="editRow !== row && row.ttl">{$ row.ttl $}</td>
7 <td class="col-2" aria-label="TTL" data-ng-if="editRow !== row && !row.ttl">(default)</td>
8 <td class="col-3" aria-label="Data" data-ng-if="editRow !== row">{$ row.rrdata $}</td>
9- <td class="col-1" data-ng-if="editRow !== row">
10+ <td class="col-1 p-table--action-cell" data-ng-if="editRow !== row">
11 <div class="u-align--right">
12 <div class="p-contextual-menu" toggle-ctrl data-ng-if="!isRecordAutogenerated(row)">
13- <button class="p-contextual-menu__toggle p-button--base" data-ng-click="toggleMenu()">
14+ <button class="p-contextual-menu__toggle p-button--base is-small" data-ng-click="toggleMenu()">
15 <i class="p-icon--contextual-menu u-no-margin--right">Actions</i>
16 </button>
17 <div class="p-contextual-menu__dropdown" role="menu" data-ng-show="isToggled">

Subscribers

People subscribed via source and target branches