Code review comment for lp:~deadlight/canonical-identity-provider/sass-tooling

Revision history for this message
Daniel Manrique (roadmr) wrote :

Here's what the linter said:

16:12:02 O: scripts/build_vanilla.py:6:74: E261 at least two spaces before inline comment
16:12:02 O: scripts/build_vanilla.py:6:80: E501 line too long (111 > 79 characters)
16:12:02 O: scripts/build_vanilla.py:9:13: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:9:15: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:9:80: E501 line too long (93 > 79 characters)
16:12:02 O: scripts/build_vanilla.py:10:17: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:10:19: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:11:18: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:11:20: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:11:80: E501 line too long (131 > 79 characters)
16:12:02 O: scripts/build_vanilla.py:12:20: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:12:22: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:13:24: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:13:26: E251 unexpected spaces around keyword / parameter equals
16:12:02 O: scripts/build_vanilla.py:13:80: E501 line too long (110 > 79 characters)
16:12:02 O: scripts/build_vanilla.py:16:80: E501 line too long (122 > 79 characters)
16:12:02 O: scripts/build_vanilla.py:19:80: E501 line too long (126 > 79 characters)

You can apply the suggested changes and run "make lint" until it's happy, then let me know so we can reapprove this.

« Back to merge proposal