Changes look good codewise, all tests pass and it looks awesome \o/
A couple of UI details:
- Formatting of the "Preferred email address" help popup is broken.
- Error messages on Password/New password/Password confirmation lack any style.
- As discussed earlier, overall UI density could be a bit more compact!
I don't think any of that is a blocker, so I'm +1 to land and try on staging.
As Daniel said, thanks for the splitting :)
Changes look good codewise, all tests pass and it looks awesome \o/
A couple of UI details:
- Formatting of the "Preferred email address" help popup is broken.
- Error messages on Password/New password/Password confirmation lack any style.
- As discussed earlier, overall UI density could be a bit more compact!
I don't think any of that is a blocker, so I'm +1 to land and try on staging.
Thanks!