Code review comment for lp:~deadlight/canonical-identity-provider/merge-3-user

Revision history for this message
Daniel Manrique (roadmr) wrote :

Thanks for the refactoring! as usual. much easier to review the actual changes separately from formatting.

Looks OK to me, I read the code (mostly reformatting and that kind of change) plus I ran this locally to visually check, didn't find any showstoppers (some tweaks might be needed for smaller-sized browser windows) but this is as discussed with Anthony, we can tweak later.

It still merges cleanly on trunk and all tests pass \o/

review: Approve

« Back to merge proposal