Code review comment for lp:~deadlight/canonical-identity-provider/merge-1-static

Revision history for this message
Daniel Manrique (roadmr) wrote :

Great!

I checked on a local copy and it all works fine, existing flows were not altered and the updated pages do have the new visuals which are as agreed.

TO be fair, those are rather uncommonly-visited pages and some are a bit outdated but 1) not your fault :) 2) makes perfect sense to start the vanilla updates at this level and move toward trickier parts of the code base.

I'll try to get one extra review on this and aim to merge/deploy to staging early next week so we can iron out any kinks on an actual deployment.

Thanks!

(I made a couple of non-blocking nitpicks below, can be fixed here or on a subsequent mp, or maybe do a massive copyright cleanup later).

review: Approve

« Back to merge proposal