Code review comment for lp:~deadlight/canonical-identity-provider/form-error-states

Revision history for this message
Maximiliano Bertacchini (maxiberta) wrote :

Nice! Looks good to me. But there are 3 related failing tests, which fortunately look trivial to fix :)

Also, it'd be great if passwords field errors in "My account" had the same rendering style. Have you considered that?

Thanks!

review: Needs Fixing

« Back to merge proposal