Merge lp:~dcow90/myro-c++/extern-c into lp:myro-c++
Status: | Merged |
---|---|
Approved by: | John Hoare |
Approved revision: | 84 |
Merged at revision: | 100 |
Proposed branch: | lp:~dcow90/myro-c++/extern-c |
Merge into: | lp:myro-c++ |
Diff against target: |
12 lines (+1/-1) 1 file modified
headers/Scribbler.h (+1/-1) |
To merge this branch: | bzr merge lp:~dcow90/myro-c++/extern-c |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Hoare | Approve | ||
Review via email: mp+66661@code.launchpad.net |
Description of the change
The change is described in detail in the commit. I changed one function prototype so it is compatible with the use of extern "C" (I believe that was the issue). My guess is, when using extern "C", functions overloaded with a void version and a null string version:
function();
and
function (string s = "");
break down both into the same signature to the compiler. Which is why the compiler was complaining.
Simply changing the prototype to:
function (string s);
fixes the error and allows us to compile against the Scribbler header.
Please feel free to ask any questions. This was a confusing error to come across and one that didn't manifest until recently and under special conditions so I may need to explain it better.