Code review comment for lp:~dcaro/clicompanion/fix-923535

Revision history for this message
Marek BardoĊ„ski (bdfhjk) wrote :

2012/3/4 David Caro <email address hidden>

> Fixed, the regexp matching launchpad branches was too permissive and false
> positives were matched. It should be fixed now (it's a lot more strict, so
> maybe real urls that have some strange chars in them are not matched
> correctly, but now most of urls will match).
>
> Also you don't need to hit enter for the url to get underscored ;)
>
> --
> https://code.launchpad.net/~dcaro/clicompanion/fix-923535/+merge/90633<https://code.launchpad.net/%7Edcaro/clicompanion/fix-923535/+merge/90633>
> You are reviewing the proposed merge of lp:~dcaro/clicompanion/fix-923535
> into lp:clicompanion.
>

OK, I will test it soon.

« Back to merge proposal