Code review comment for lp:~dcaro/clicompanion/fix-913436

Revision history for this message
Marek BardoĊ„ski (bdfhjk) wrote :

Work fine.

I'm curious why did You deleted some lines regarding drag'n'drop, but it stil work.

Could You, David, look at a bug which I discovered testing d'n'd:

"""
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/plugins/LocalCommandList.py", line 356, in drag_data_received_event
    self.cmnds.drag_n_drop(orig, dest, before=True)
  File "/usr/local/lib/python2.7/dist-packages/plugins/LocalCommandList.py", line 599, in drag_n_drop
    i2 = self.commands.index(cmd2)
ValueError: ['dpkg -l ?', 'package', 'Find version of a package'] is not in list
/usr/local/lib/python2.7/dist-packages/clicompanionlib/view.py:524: GtkWarning: IA__gtk_tree_drag_dest_drag_data_received: assertion `iface->drag_data_received != NULL' failed
  gtk.main()

"""

I will occur when You drop command over the list.

review: Approve

« Back to merge proposal