Merge lp:~dbusmenu-team/ubuntu/precise/libdbusmenu/upstream into lp:~ubuntu-desktop/libdbusmenu/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 176
Proposed branch: lp:~dbusmenu-team/ubuntu/precise/libdbusmenu/upstream
Merge into: lp:~ubuntu-desktop/libdbusmenu/ubuntu
Diff against target: 352 lines (+113/-35)
12 files modified
ChangeLog (+50/-0)
configure (+11/-11)
configure.ac (+3/-3)
debian/changelog (+8/-0)
docs/libdbusmenu-glib/reference/html/ch01.html (+1/-1)
docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html (+2/-2)
docs/libdbusmenu-glib/reference/version.xml (+1/-1)
docs/libdbusmenu-glib/reference/xml/menuitem.xml (+2/-2)
docs/libdbusmenu-gtk/reference/html/ch01.html (+1/-1)
docs/libdbusmenu-gtk/reference/version.xml (+1/-1)
libdbusmenu-gtk/client.c (+21/-9)
libdbusmenu-gtk/parser.c (+12/-4)
To merge this branch: bzr merge lp:~dbusmenu-team/ubuntu/precise/libdbusmenu/upstream
Reviewer Review Type Date Requested Status
Sebastien Bacher Pending
Ken VanDine Pending
Review via email: mp+96829@code.launchpad.net

Description of the change

Fix gedit for Seb

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'ChangeLog'
--- ChangeLog 2012-03-08 15:58:14 +0000
+++ ChangeLog 2012-03-09 20:38:32 +0000
@@ -1,5 +1,55 @@
1# Generated by Makefile. Do not edit.1# Generated by Makefile. Do not edit.
22
32012-03-09 Ted Gould <ted@gould.cx>
4
5 0.5.94
6
72012-03-09 Ted Gould <ted@gould.cx>
8
9 Removing underscores in the ATK name
10
112012-03-09 Ted Gould <ted@gould.cx>
12
13 Restructuring slightly to have two cases, allocating memory and not allocating
14
152012-03-09 Luke Yelavich <luke.yelavich@canonical.com>
16
17 Remove the underscores used for mnewmonics, as orca speaks them, which is not
18 what we want.
19
202012-03-09 Ted Gould <ted@gould.cx>
21
22 Making sure to disconnect theme changed handler universally
23
242012-03-09 Ted Gould <ted@gould.cx>
25
26 Attaching bug
27
282012-03-09 Ted Gould <ted@gould.cx>
29
30 Missing a couple of cases of removing the signal handler and clearing the stored value
31
322012-03-08 Ted Gould <ted@gould.cx>
33
34 Making sure the ATK object name always gets set to the label if nothing else
35
362012-03-08 Luke Yelavich <luke.yelavich@canonical.com>
37
38 Set the accessible name from the dbusmenu item label. THis is a work-around until GTK follows atk docs.
39
402012-03-08 Luke Yelavich <luke.yelavich@canonical.com>
41
42 Merge from trunk.
43
442012-02-17 Luke Yelavich <luke.yelavich@canonical.com>
45
46 Do not set the accessible name to an empty string if the accessible_desc
47 property = NULL. Yes this was recently changed so that dbusmenu conformed
48 to Atk documentation, but the GTK menu item accessibility code does not yet
49 conform to sed documentation. As a result, all dbusmenu menu items that do not
50 have the accessible_desc property set end up getting an empty string for their
51 accessible name. In the long term, GTK accessibility needs to be fixed.
52
32012-03-08 Ted Gould <ted@gould.cx>532012-03-08 Ted Gould <ted@gould.cx>
454
5 0.5.9355 0.5.93
656
=== modified file 'configure'
--- configure 2012-03-08 16:01:54 +0000
+++ configure 2012-03-09 20:38:32 +0000
@@ -1,6 +1,6 @@
1#! /bin/sh1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.2# Guess values for system-dependent variables and create Makefiles.
3# Generated by GNU Autoconf 2.68 for libdbusmenu 0.5.93.3# Generated by GNU Autoconf 2.68 for libdbusmenu 0.5.94.
4#4#
5# Report bugs to <ted@canonical.com>.5# Report bugs to <ted@canonical.com>.
6#6#
@@ -572,8 +572,8 @@
572# Identity of this package.572# Identity of this package.
573PACKAGE_NAME='libdbusmenu'573PACKAGE_NAME='libdbusmenu'
574PACKAGE_TARNAME='libdbusmenu'574PACKAGE_TARNAME='libdbusmenu'
575PACKAGE_VERSION='0.5.93'575PACKAGE_VERSION='0.5.94'
576PACKAGE_STRING='libdbusmenu 0.5.93'576PACKAGE_STRING='libdbusmenu 0.5.94'
577PACKAGE_BUGREPORT='ted@canonical.com'577PACKAGE_BUGREPORT='ted@canonical.com'
578PACKAGE_URL=''578PACKAGE_URL=''
579579
@@ -1437,7 +1437,7 @@
1437 # Omit some internal or obsolete options to make the list less imposing.1437 # Omit some internal or obsolete options to make the list less imposing.
1438 # This message is too long to be a string in the A/UX 3.1 sh.1438 # This message is too long to be a string in the A/UX 3.1 sh.
1439 cat <<_ACEOF1439 cat <<_ACEOF
1440\`configure' configures libdbusmenu 0.5.93 to adapt to many kinds of systems.1440\`configure' configures libdbusmenu 0.5.94 to adapt to many kinds of systems.
14411441
1442Usage: $0 [OPTION]... [VAR=VALUE]...1442Usage: $0 [OPTION]... [VAR=VALUE]...
14431443
@@ -1507,7 +1507,7 @@
15071507
1508if test -n "$ac_init_help"; then1508if test -n "$ac_init_help"; then
1509 case $ac_init_help in1509 case $ac_init_help in
1510 short | recursive ) echo "Configuration of libdbusmenu 0.5.93:";;1510 short | recursive ) echo "Configuration of libdbusmenu 0.5.94:";;
1511 esac1511 esac
1512 cat <<\_ACEOF1512 cat <<\_ACEOF
15131513
@@ -1656,7 +1656,7 @@
1656test -n "$ac_init_help" && exit $ac_status1656test -n "$ac_init_help" && exit $ac_status
1657if $ac_init_version; then1657if $ac_init_version; then
1658 cat <<\_ACEOF1658 cat <<\_ACEOF
1659libdbusmenu configure 0.5.931659libdbusmenu configure 0.5.94
1660generated by GNU Autoconf 2.681660generated by GNU Autoconf 2.68
16611661
1662Copyright (C) 2010 Free Software Foundation, Inc.1662Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2027,7 +2027,7 @@
2027This file contains any messages produced by compilers while2027This file contains any messages produced by compilers while
2028running configure, to aid debugging if configure makes a mistake.2028running configure, to aid debugging if configure makes a mistake.
20292029
2030It was created by libdbusmenu $as_me 0.5.93, which was2030It was created by libdbusmenu $as_me 0.5.94, which was
2031generated by GNU Autoconf 2.68. Invocation command line was2031generated by GNU Autoconf 2.68. Invocation command line was
20322032
2033 $ $0 $@2033 $ $0 $@
@@ -2848,7 +2848,7 @@
28482848
2849# Define the identity of the package.2849# Define the identity of the package.
2850 PACKAGE=libdbusmenu2850 PACKAGE=libdbusmenu
2851 VERSION=0.5.932851 VERSION=0.5.94
28522852
28532853
2854# Some tools Automake needs.2854# Some tools Automake needs.
@@ -14423,7 +14423,7 @@
14423###########################14423###########################
1442414424
14425LIBDBUSMENU_CURRENT=414425LIBDBUSMENU_CURRENT=4
14426LIBDBUSMENU_REVISION=1014426LIBDBUSMENU_REVISION=11
14427LIBDBUSMENU_AGE=014427LIBDBUSMENU_AGE=0
1442814428
1442914429
@@ -15777,7 +15777,7 @@
15777# report actual input values of CONFIG_FILES etc. instead of their15777# report actual input values of CONFIG_FILES etc. instead of their
15778# values after options handling.15778# values after options handling.
15779ac_log="15779ac_log="
15780This file was extended by libdbusmenu $as_me 0.5.93, which was15780This file was extended by libdbusmenu $as_me 0.5.94, which was
15781generated by GNU Autoconf 2.68. Invocation command line was15781generated by GNU Autoconf 2.68. Invocation command line was
1578215782
15783 CONFIG_FILES = $CONFIG_FILES15783 CONFIG_FILES = $CONFIG_FILES
@@ -15843,7 +15843,7 @@
15843cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=115843cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
15844ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"15844ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
15845ac_cs_version="\\15845ac_cs_version="\\
15846libdbusmenu config.status 0.5.9315846libdbusmenu config.status 0.5.94
15847configured by $0, generated by GNU Autoconf 2.68,15847configured by $0, generated by GNU Autoconf 2.68,
15848 with options \\"\$ac_cs_config\\"15848 with options \\"\$ac_cs_config\\"
1584915849
1585015850
=== modified file 'configure.ac'
--- configure.ac 2012-03-08 16:01:54 +0000
+++ configure.ac 2012-03-09 20:38:32 +0000
@@ -1,11 +1,11 @@
11
2AC_INIT(libdbusmenu, 0.5.93, ted@canonical.com)2AC_INIT(libdbusmenu, 0.5.94, ted@canonical.com)
3AC_COPYRIGHT([Copyright 2009,2010 Canonical])3AC_COPYRIGHT([Copyright 2009,2010 Canonical])
44
5AC_PREREQ(2.62)5AC_PREREQ(2.62)
66
7AM_CONFIG_HEADER(config.h)7AM_CONFIG_HEADER(config.h)
8AM_INIT_AUTOMAKE(libdbusmenu, 0.5.93, [-Wno-portability])8AM_INIT_AUTOMAKE(libdbusmenu, 0.5.94, [-Wno-portability])
99
10AM_MAINTAINER_MODE10AM_MAINTAINER_MODE
1111
@@ -165,7 +165,7 @@
165###########################165###########################
166166
167LIBDBUSMENU_CURRENT=4167LIBDBUSMENU_CURRENT=4
168LIBDBUSMENU_REVISION=10168LIBDBUSMENU_REVISION=11
169LIBDBUSMENU_AGE=0169LIBDBUSMENU_AGE=0
170170
171AC_SUBST(LIBDBUSMENU_CURRENT)171AC_SUBST(LIBDBUSMENU_CURRENT)
172172
=== modified file 'debian/changelog'
--- debian/changelog 2012-03-09 12:03:10 +0000
+++ debian/changelog 2012-03-09 20:38:32 +0000
@@ -1,3 +1,11 @@
1libdbusmenu (0.5.94-0ubuntu1~ppa1) precise; urgency=low
2
3 * New upstream release.
4 * Fixing setting name of ATK objects
5 * Cleaning up a warning on shutdown (LP: #950762)
6
7 -- Ted Gould <ted@ubuntu.com> Fri, 09 Mar 2012 14:35:38 -0600
8
1libdbusmenu (0.5.93-0ubuntu1) precise; urgency=low9libdbusmenu (0.5.93-0ubuntu1) precise; urgency=low
210
3 * New upstream release.11 * New upstream release.
412
=== modified file 'docs/libdbusmenu-glib/reference/html/ch01.html'
--- docs/libdbusmenu-glib/reference/html/ch01.html 2012-03-08 15:58:14 +0000
+++ docs/libdbusmenu-glib/reference/html/ch01.html 2012-03-09 20:38:32 +0000
@@ -21,7 +21,7 @@
21</tr></table>21</tr></table>
22<div class="chapter">22<div class="chapter">
23<div class="titlepage"><div><div><h2 class="title">23<div class="titlepage"><div><div><h2 class="title">
24<a name="idp114464"></a>API</h2></div></div></div>24<a name="idp3882768"></a>API</h2></div></div></div>
25<div class="toc"><dl>25<div class="toc"><dl>
26<dt>26<dt>
27<span class="refentrytitle"><a href="libdbusmenu-glib-DbusmenuServer.html">DbusmenuServer</a></span><span class="refpurpose"> — The server signals changed and27<span class="refentrytitle"><a href="libdbusmenu-glib-DbusmenuServer.html">DbusmenuServer</a></span><span class="refpurpose"> — The server signals changed and
2828
=== modified file 'docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html'
--- docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html 2012-01-31 05:20:48 +0000
+++ docs/libdbusmenu-glib/reference/html/libdbusmenu-glib-DbusmenuMenuitem.html 2012-03-09 20:38:32 +0000
@@ -1568,8 +1568,8 @@
1568</tr>1568</tr>
1569<tr>1569<tr>
1570<td><p><span class="term"><span class="emphasis"><em>Returns</em></span> :</span></p></td>1570<td><p><span class="term"><span class="emphasis"><em>Returns</em></span> :</span></p></td>
1571<td>A list of strings or NULL if there are1571<td>A list of
1572none. <span class="annotation">[<acronym title="Free data container after the code is done."><span class="acronym">transfer container</span></acronym>]</span>1572strings or NULL if there are none. <span class="annotation">[<acronym title="Free data container after the code is done."><span class="acronym">transfer container</span></acronym>][<acronym title="Generics and defining elements of containers and arrays."><span class="acronym">element-type</span></acronym> utf8]</span>
1573</td>1573</td>
1574</tr>1574</tr>
1575</tbody>1575</tbody>
15761576
=== modified file 'docs/libdbusmenu-glib/reference/version.xml'
--- docs/libdbusmenu-glib/reference/version.xml 2012-03-08 16:01:54 +0000
+++ docs/libdbusmenu-glib/reference/version.xml 2012-03-09 20:38:32 +0000
@@ -1,1 +1,1 @@
10.5.9310.5.94
22
=== modified file 'docs/libdbusmenu-glib/reference/xml/menuitem.xml'
--- docs/libdbusmenu-glib/reference/xml/menuitem.xml 2012-01-31 05:20:48 +0000
+++ docs/libdbusmenu-glib/reference/xml/menuitem.xml 2012-03-09 20:38:32 +0000
@@ -1137,8 +1137,8 @@
1137</para><variablelist role="params">1137</para><variablelist role="params">
1138<varlistentry><term><parameter>mi</parameter>&#160;:</term>1138<varlistentry><term><parameter>mi</parameter>&#160;:</term>
1139<listitem><simpara><link linkend="DbusmenuMenuitem"><type>DbusmenuMenuitem</type></link> to list the properties on</simpara></listitem></varlistentry>1139<listitem><simpara><link linkend="DbusmenuMenuitem"><type>DbusmenuMenuitem</type></link> to list the properties on</simpara></listitem></varlistentry>
1140<varlistentry><term><emphasis>Returns</emphasis>&#160;:</term><listitem><simpara>A list of strings or NULL if there are1140<varlistentry><term><emphasis>Returns</emphasis>&#160;:</term><listitem><simpara>A list of
1141none. <emphasis role="annotation">[<acronym>transfer container</acronym>]</emphasis></simpara></listitem></varlistentry>1141strings or NULL if there are none. <emphasis role="annotation">[<acronym>transfer container</acronym>][<acronym>element-type</acronym> utf8]</emphasis></simpara></listitem></varlistentry>
1142</variablelist></refsect2>1142</variablelist></refsect2>
1143<refsect2 id="dbusmenu-menuitem-properties-copy" role="function">1143<refsect2 id="dbusmenu-menuitem-properties-copy" role="function">
1144<title>dbusmenu_menuitem_properties_copy ()</title>1144<title>dbusmenu_menuitem_properties_copy ()</title>
11451145
=== modified file 'docs/libdbusmenu-gtk/reference/html/ch01.html'
--- docs/libdbusmenu-gtk/reference/html/ch01.html 2012-03-08 15:58:14 +0000
+++ docs/libdbusmenu-gtk/reference/html/ch01.html 2012-03-09 20:38:32 +0000
@@ -21,7 +21,7 @@
21</tr></table>21</tr></table>
22<div class="chapter">22<div class="chapter">
23<div class="titlepage"><div><div><h2 class="title">23<div class="titlepage"><div><div><h2 class="title">
24<a name="idp3304320"></a>API</h2></div></div></div>24<a name="idp3527472"></a>API</h2></div></div></div>
25<div class="toc"><dl>25<div class="toc"><dl>
26<dt>26<dt>
27<span class="refentrytitle"><a href="libdbusmenu-gtk-DbusmenuGtkMenu.html">DbusmenuGtkMenu</a></span><span class="refpurpose"> — A GTK Menu Object that syncronizes over DBus</span>27<span class="refentrytitle"><a href="libdbusmenu-gtk-DbusmenuGtkMenu.html">DbusmenuGtkMenu</a></span><span class="refpurpose"> — A GTK Menu Object that syncronizes over DBus</span>
2828
=== modified file 'docs/libdbusmenu-gtk/reference/version.xml'
--- docs/libdbusmenu-gtk/reference/version.xml 2012-03-08 16:01:54 +0000
+++ docs/libdbusmenu-gtk/reference/version.xml 2012-03-09 20:38:32 +0000
@@ -1,1 +1,1 @@
10.5.9310.5.94
22
=== modified file 'libdbusmenu-gtk/client.c'
--- libdbusmenu-gtk/client.c 2012-02-15 17:36:32 +0000
+++ libdbusmenu-gtk/client.c 2012-03-09 20:38:32 +0000
@@ -735,17 +735,29 @@
735 return;735 return;
736 }736 }
737737
738 const gchar * setname = NULL;
739738
740 if (variant != NULL) {739 if (variant != NULL) {
741 setname = g_variant_get_string(variant, NULL);740 const gchar * setname = NULL;
742 }741 setname = g_variant_dup_string(variant, NULL);
743742 atk_object_set_name(aobj, setname);
744 if (setname == NULL) {743 } else {
745 setname = "";744 /* The atk docs advise to set the name of the atk object to an empty
746 }745 * string, but GTK doesn't yet do the same, and setting the name to NULL
747746 * causes tests to fail.
748 atk_object_set_name(aobj, setname);747 */
748 gchar * setname = NULL;
749 const gchar * label = NULL;
750 /* We don't want the underscore for mnewmonics */
751 label = dbusmenu_menuitem_property_get(mi, DBUSMENU_MENUITEM_PROP_LABEL);
752
753 GRegex * regex = g_regex_new ("_", 0, 0, NULL);
754 setname = g_regex_replace_literal (regex, label, -1, 0, "", 0, NULL);
755 g_regex_unref(regex);
756
757 atk_object_set_name(aobj, setname);
758 g_free(setname);
759 }
760
749 return;761 return;
750}762}
751763
752764
=== modified file 'libdbusmenu-gtk/parser.c'
--- libdbusmenu-gtk/parser.c 2012-03-08 16:01:54 +0000
+++ libdbusmenu-gtk/parser.c 2012-03-09 20:38:32 +0000
@@ -229,7 +229,12 @@
229static void229static void
230widget_freed (gpointer data, GObject * obj)230widget_freed (gpointer data, GObject * obj)
231{231{
232 g_signal_handlers_disconnect_by_func(gtk_icon_theme_get_default(), G_CALLBACK(theme_changed_cb), obj);232 ParserData * pdata = (ParserData *)data;
233
234 if (pdata->theme_changed_sig != 0) {
235 g_signal_handler_disconnect(gtk_icon_theme_get_default(), pdata->theme_changed_sig);
236 pdata->theme_changed_sig = 0;
237 }
233238
234 return;239 return;
235}240}
@@ -242,9 +247,12 @@
242 ParserData *pdata = (ParserData *)g_object_get_data(G_OBJECT(obj), PARSER_DATA);247 ParserData *pdata = (ParserData *)g_object_get_data(G_OBJECT(obj), PARSER_DATA);
243248
244 if (pdata != NULL && pdata->widget != NULL) {249 if (pdata != NULL && pdata->widget != NULL) {
245 g_signal_handlers_disconnect_by_func(gtk_icon_theme_get_default(), G_CALLBACK(theme_changed_cb), pdata->widget);250 if (pdata->theme_changed_sig != 0) {
251 g_signal_handler_disconnect(gtk_icon_theme_get_default(), pdata->theme_changed_sig);
252 pdata->theme_changed_sig = 0;
253 }
246 g_object_steal_data(G_OBJECT(pdata->widget), CACHED_MENUITEM);254 g_object_steal_data(G_OBJECT(pdata->widget), CACHED_MENUITEM);
247 g_object_weak_unref(G_OBJECT(pdata->widget), widget_freed, NULL);255 g_object_weak_unref(G_OBJECT(pdata->widget), widget_freed, pdata);
248 }256 }
249}257}
250258
@@ -286,7 +294,7 @@
286 g_object_set_data_full(G_OBJECT(item), PARSER_DATA, pdata, parse_data_free);294 g_object_set_data_full(G_OBJECT(item), PARSER_DATA, pdata, parse_data_free);
287295
288 g_object_weak_ref(G_OBJECT(item), dbusmenu_item_freed, NULL);296 g_object_weak_ref(G_OBJECT(item), dbusmenu_item_freed, NULL);
289 g_object_weak_ref(G_OBJECT(widget), widget_freed, NULL);297 g_object_weak_ref(G_OBJECT(widget), widget_freed, pdata);
290298
291 pdata->widget = widget;299 pdata->widget = widget;
292 g_object_add_weak_pointer(G_OBJECT (widget), (gpointer*)&pdata->widget);300 g_object_add_weak_pointer(G_OBJECT (widget), (gpointer*)&pdata->widget);

Subscribers

People subscribed via source and target branches

to all changes: