Merge lp:~dbusmenu-team/libdbusmenu/ubuntu into lp:~ubuntu-desktop/libdbusmenu/ubuntu

[Ted Gould]

[lp:~dbusmenu-team/libdbusmenu/ubuntu]

134. By Ken VanDine on 2011-03-16

releasing version 0.3.102-0ubuntu1

=== modified file 'ChangeLog'
--- ChangeLog	2011-03-10 17:03:04 +0000
+++ ChangeLog	2011-03-16 19:16:36 +0000
@@ -1,5 +1,108 @@
 # Generated by Makefile. Do not edit.
 
[phone]  Ted Gould  <[e-mail]>
+
+	0.3.102
+
[phone]  Ted Gould  <[e-mail]>
+
+	Add handling for children getting removed
+
[phone]  Ted Gould  <[e-mail]>
+
+	Update to current trunk
+
[phone]  Ted Gould  <[e-mail]>
+
+	If we call the parse function and we already have the menu item built for the passed in value let's just use that and not bother looking any further.
+
[phone]  Ted Gould  <[e-mail]>
+
+	Disconnecting the child removed handlers
+
[phone]  Ted Gould  <[e-mail]>
+
+	Removing the dbusmenu menuitem from the parent if it gets removed on the GTK side
+
[phone]  Ted Gould  <[e-mail]>
+
+	Add a callback for child-removed as well
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding defines for the event identifiers
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding event defines to the documentation.
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding opened and closed to the spec
+
[phone]  Ted Gould  <[e-mail]>
+
+	Using the new defines
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding defines for the event ids
+
[phone]  Ted Gould  <[e-mail]>
+
+	Send open and close signals when menu visibility changes.
+
[phone]  Michael Terry  <[e-mail]>
+
+	add opened and closed events
+
[phone]  Ted Gould  <[e-mail]>
+
+	Empty images are images too
+
[phone]  Michael Terry  <[e-mail]>
+
+	handle empty image types
+
[phone]  Ted Gould  <[e-mail]>
+
+	Removing a noisy warning
+
[phone]  Ted Gould  <[e-mail]>
+
+	Not everything is a menuitem
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding needed dependencies to pkgconfig files
+
[phone]  Ted Gould  <[e-mail]>
+
+	Adding needed requirements to pkgconfig files.
+
[phone]  Ted Gould  <[e-mail]>
+
+	Handle NULL better in finding the label
+
[phone]  Michael Terry  <[e-mail]>
+
+	be a little more cautious about pointers in sanitize_label_text
+
[phone]  Ted Gould  <[e-mail]>
+
+	Lots of memory leak fixes
+
[phone]  Chris Coulson  <[e-mail]>
+
+	The g_variant_get_* family of calls which return a GVariant
+	actually return reference counted, non-floating variant. Ensure that we
+	always keep pointers to these so that we can properly unref them.
+	
+	The same also applies to g_variant_iter_next_value.
+	
+	Also fix a couple of other minor leaks along the way. This fixes
+	LP: #722972
+
 2011-03-10  Ted Gould  <[e-mail]>
 
 	0.3.101
 
=== modified file 'configure'
--- configure	2011-03-10 17:05:16 +0000
+++ configure	2011-03-16 19:16:36 +0000
@@ -1,6 +1,6 @@
 #! /bin/sh
 # Guess values for system-dependent variables and create Makefiles.
-# Generated by GNU Autoconf 2.67 for libdbusmenu 0.3.101.
+# Generated by GNU Autoconf 2.67 for libdbusmenu 0.3.102.
 #
 # Report bugs to <[e-mail]>.
 #
@@ -703,8 +703,8 @@
 # Identity of this package.
 PACKAGE_NAME='libdbusmenu'
 PACKAGE_TARNAME='libdbusmenu'
-PACKAGE_VERSION='0.3.101'
-PACKAGE_STRING='libdbusmenu 0.3.101'
+PACKAGE_VERSION='0.3.102'
+PACKAGE_STRING='libdbusmenu 0.3.102'
 PACKAGE_BUGREPORT='[e-mail]'
 PACKAGE_URL=''
 
@@ -1541,7 +1541,7 @@
   # Omit some internal or obsolete options to make the list less imposing.
   # This message is too long to be a string in the A/UX 3.1 sh.
   cat <<_ACEOF
-\`configure' configures libdbusmenu 0.3.101 to adapt to many kinds of systems.
+\`configure' configures libdbusmenu 0.3.102 to adapt to many kinds of systems.
 
 Usage: $0 [OPTION]... [VAR=VALUE]...
 
@@ -1611,7 +1611,7 @@
 
 if test -n "$ac_init_help"; then
   case $ac_init_help in
-     short | recursive ) echo "Configuration of libdbusmenu 0.3.101:";;
+     short | recursive ) echo "Configuration of libdbusmenu 0.3.102:";;
    esac
   cat <<\_ACEOF
 
@@ -1751,7 +1751,7 @@
 test -n "$ac_init_help" && exit $ac_status
 if $ac_init_version; then
   cat <<\_ACEOF
-libdbusmenu configure 0.3.101
+libdbusmenu configure 0.3.102
 generated by GNU Autoconf 2.67
 
 Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2122,7 +2122,7 @@
 This file contains any messages produced by compilers while
 running configure, to aid debugging if configure makes a mistake.
 
-It was created by libdbusmenu $as_me 0.3.101, which was
+It was created by libdbusmenu $as_me 0.3.102, which was
 generated by GNU Autoconf 2.67.  Invocation command line was
 
   $ $0 $@
@@ -2943,7 +2943,7 @@
 
 # Define the identity of the package.
  PACKAGE=libdbusmenu
- VERSION=0.3.101
+ VERSION=0.3.102
 
 
 # Some tools Automake needs.
@@ -13294,7 +13294,7 @@
 ###########################
 
 LIBDBUSMENU_CURRENT=3
-LIBDBUSMENU_REVISION=9
+LIBDBUSMENU_REVISION=10
 LIBDBUSMENU_AGE=0
 
 
@@ -14616,7 +14616,7 @@
 # report actual input values of CONFIG_FILES etc. instead of their
 # values after options handling.
 ac_log="
-This file was extended by libdbusmenu $as_me 0.3.101, which was
+This file was extended by libdbusmenu $as_me 0.3.102, which was
 generated by GNU Autoconf 2.67.  Invocation command line was
 
   CONFIG_FILES    = $CONFIG_FILES
@@ -14682,7 +14682,7 @@
 cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
 ac_cs_version="\\
-libdbusmenu config.status 0.3.101
+libdbusmenu config.status 0.3.102
 configured by $0, generated by GNU Autoconf 2.67,
   with options \\"\$ac_cs_config\\"
 
 
=== modified file 'configure.ac'
--- configure.ac	2011-03-10 17:05:16 +0000
+++ configure.ac	2011-03-16 19:16:36 +0000
@@ -1,11 +1,11 @@
 
-AC_INIT(libdbusmenu, 0.3.101, [e-mail])
+AC_INIT(libdbusmenu, 0.3.102, [e-mail])
 AC_COPYRIGHT([Copyright 2009,2010 Canonical])
 
 AC_PREREQ(2.62)
 
 AM_CONFIG_HEADER(config.h)
-AM_INIT_AUTOMAKE(libdbusmenu, 0.3.101, [-Wno-portability])
+AM_INIT_AUTOMAKE(libdbusmenu, 0.3.102, [-Wno-portability])
 
 AM_MAINTAINER_MODE
 
@@ -134,7 +134,7 @@
 ###########################
 
 LIBDBUSMENU_CURRENT=3
-LIBDBUSMENU_REVISION=9
+LIBDBUSMENU_REVISION=10
 LIBDBUSMENU_AGE=0
 
 AC_SUBST(LIBDBUSMENU_CURRENT)
 
=== modified file 'debian/changelog'
--- debian/changelog	2011-03-10 19:11:17 +0000
+++ debian/changelog	2011-03-16 19:16:36 +0000
@@ -1,3 +1,16 @@
+libdbusmenu (0.3.102-0ubuntu1~ppa1) natty; urgency=low
+
+  * New upstream release.
+    ∘ Remove child items when they're removed by GTK
+    ∘ Adding opened and closed events for menu visibility
+    ∘ Handle empty image types
+    ∘ Remove critical warning on parser menuitem check (LP: #733918)
+    ∘ Fix dependencies in pkgconfig files (LP: #733263)
+    ∘ Handle NULL labels (LP: #733688)
+    ∘ Fix memory leaks from variants (LP: #722972)
+
+ -- Ted Gould <[e-mail]>  Wed, 16 Mar 2011 14:08:13 -0500
+
 libdbusmenu (0.3.101-0ubuntu1) natty; urgency=low
 
   * New upstream release.
 
=== modified file 'docs/libdbusmenu-glib/reference/libdbusmenu-glib-sections.txt'
--- docs/libdbusmenu-glib/reference/libdbusmenu-glib-sections.txt	2011-03-03 18:27:37 +0000
+++ docs/libdbusmenu-glib/reference/libdbusmenu-glib-sections.txt	2011-03-16 19:16:36 +0000
@@ -70,6 +70,9 @@
 DBUSMENU_MENUITEM_SHORTCUT_CONTROL
 DBUSMENU_MENUITEM_SHORTCUT_SHIFT
 DBUSMENU_MENUITEM_SHORTCUT_SUPER
+DBUSMENU_MENUITEM_EVENT_ACTIVATED
+DBUSMENU_MENUITEM_EVENT_CLOSED
+DBUSMENU_MENUITEM_EVENT_OPENED
 DbusmenuMenuitem
 dbusmenu_menuitem_about_to_show_cb
 dbusmenu_menuitem_buildvariant_slot_t
 
=== modified file 'docs/libdbusmenu-glib/reference/version.xml'
--- docs/libdbusmenu-glib/reference/version.xml	2011-03-10 17:05:16 +0000
+++ docs/libdbusmenu-glib/reference/version.xml	2011-03-16 19:16:36 +0000
@@ -1,1 +1,1 @@
-0.3.101
+0.3.102
 
=== modified file 'docs/libdbusmenu-gtk/reference/version.xml'
--- docs/libdbusmenu-gtk/reference/version.xml	2011-03-10 17:05:16 +0000
+++ docs/libdbusmenu-gtk/reference/version.xml	2011-03-16 19:16:36 +0000
@@ -1,1 +1,1 @@
-0.3.101
+0.3.102
 
=== modified file 'libdbusmenu-glib/client.c'
--- libdbusmenu-glib/client.c	2011-03-10 17:05:16 +0000
+++ libdbusmenu-glib/client.c	2011-03-16 19:16:36 +0000
@@ -598,20 +598,27 @@
 	}
 
 	/* Callback all the folks we can find */
-	GVariantIter * iter = g_variant_iter_new(g_variant_get_child_value(params, 0));
-	GVariant * child;
+	GVariant * child = g_variant_get_child_value(params, 0);
+	GVariantIter * iter = g_variant_iter_new(child);
+	g_variant_unref(child);
 	while ((child = g_variant_iter_next_value(iter)) != NULL) {
 		if (g_strcmp0(g_variant_get_type_string(child), "(ia{sv})") != 0) {
 			g_warning("Properties return signature is not '(ia{sv})' it is '%s'", g_variant_get_type_string(child));
+			g_variant_unref(child);
 			continue;
 		}
 
-		gint id = g_variant_get_int32(g_variant_get_child_value(child, 0));
+		GVariant * idv = g_variant_get_child_value(child, 0);
+		gint id = g_variant_get_int32(idv);
+		g_variant_unref(idv);
+
 		GVariant * properties = g_variant_get_child_value(child, 1);
 
 		properties_listener_t * listener = find_listener(listeners, 0, id);
 		if (listener == NULL) {
 			g_warning("Unable to find listener for ID %d", id);
+			g_variant_unref(properties);
+			g_variant_unref(child);
 			continue;
 		}
 
@@ -621,6 +628,8 @@
 		} else {
 			g_warning("Odd, we've already replied to the listener on ID %d", id);
 		}
+		g_variant_unref(properties);
+		g_variant_unref(child);
 	}
 	g_variant_iter_free(iter);
 	g_variant_unref(params);
@@ -676,7 +685,9 @@
 	GVariant * variant_ids = g_variant_builder_end(&builder);
 
 	/* Build up a prop list to pass */
-	g_variant_builder_init(&builder, g_variant_type_new("as"));
+	GVariantType * type = g_variant_type_new("as");
+	g_variant_builder_init(&builder, type);
+	g_variant_type_free(type);
 	/* TODO: need to use delayed property list here */
 	GVariant * variant_props = g_variant_builder_end(&builder);
 
@@ -1050,12 +1061,13 @@
 	/* Check the text direction if available */
 	GVariant * textdir = g_dbus_proxy_get_cached_property(priv->menuproxy, "TextDirection");
 	if (textdir != NULL) {
-		GVariant * str = textdir;
-		if (g_variant_is_of_type(str, G_VARIANT_TYPE_VARIANT)) {
-			str = g_variant_get_variant(str);
+		if (g_variant_is_of_type(textdir, G_VARIANT_TYPE_VARIANT)) {
+			GVariant * tmp =  g_variant_get_variant(textdir);
+			g_variant_unref(textdir);
+			textdir = tmp;
 		}
 
-		priv->text_direction = dbusmenu_text_direction_get_value_from_nick(g_variant_get_string(str, NULL));
+		priv->text_direction = dbusmenu_text_direction_get_value_from_nick(g_variant_get_string(textdir, NULL));
 		g_object_notify(G_OBJECT(user_data), DBUSMENU_CLIENT_PROP_TEXT_DIRECTION);
 
 		g_variant_unref(textdir);
@@ -1063,13 +1075,14 @@
 
 	/* Check the status if available */
 	GVariant * status = g_dbus_proxy_get_cached_property(priv->menuproxy, "Status");
-	if (textdir != NULL) {
-		GVariant * str = status;
-		if (g_variant_is_of_type(str, G_VARIANT_TYPE_VARIANT)) {
-			str = g_variant_get_variant(str);
+	if (status != NULL) {
+		if (g_variant_is_of_type(status, G_VARIANT_TYPE_VARIANT)) {
+			GVariant * tmp = g_variant_get_variant(status);
+			g_variant_unref(status);
+			status = tmp;
 		}
 
-		priv->status = dbusmenu_status_get_value_from_nick(g_variant_get_string(str, NULL));
+		priv->status = dbusmenu_status_get_value_from_nick(g_variant_get_string(status, NULL));
 		g_object_notify(G_OBJECT(user_data), DBUSMENU_CLIENT_PROP_STATUS);
 
 		g_variant_unref(status);
@@ -1142,20 +1155,22 @@
 	g_variant_iter_init(&iters, properties);
 	while (g_variant_iter_next(&iters, "{sv}", &key, &value)) {
 		if (g_strcmp0(key, "TextDirection") == 0) {
-			GVariant * str = value;
-			if (g_variant_is_of_type(str, G_VARIANT_TYPE_VARIANT)) {
-				str = g_variant_get_variant(str);
+			if (g_variant_is_of_type(value, G_VARIANT_TYPE_VARIANT)) {
+				GVariant * tmp = g_variant_get_variant(value);
+				g_variant_unref(value);
+				value = tmp;
 			}
 
-			priv->text_direction = dbusmenu_text_direction_get_value_from_nick(g_variant_get_string(str, NULL));
+			priv->text_direction = dbusmenu_text_direction_get_value_from_nick(g_variant_get_string(value, NULL));
 		}
 		if (g_strcmp0(key, "Status") == 0) {
-			GVariant * str = value;
-			if (g_variant_is_of_type(str, G_VARIANT_TYPE_VARIANT)) {
-				str = g_variant_get_variant(str);
+			if (g_variant_is_of_type(value, G_VARIANT_TYPE_VARIANT)) {
+				GVariant * tmp = g_variant_get_variant(value);
+				g_variant_unref(value);
+				value = tmp;
 			}
 
-			priv->status = dbusmenu_status_get_value_from_nick(g_variant_get_string(str, NULL));
+			priv->status = dbusmenu_status_get_value_from_nick(g_variant_get_string(value, NULL));
 		}
 		if (g_strcmp0(key, "IconThemePath") == 0) {
 			if (priv->icon_dirs != NULL) {
@@ -1224,11 +1239,14 @@
 		/* Remove before adding just incase there is a duplicate, against the
 		   rules, but we can handle it so let's do it. */
 		GVariantIter ritems;
-		g_variant_iter_init(&ritems, g_variant_get_child_value(params, 1));
+		GVariant * ritemsv = g_variant_get_child_value(params, 1);
+		g_variant_iter_init(&ritems, ritemsv);
 
 		GVariant * ritem;
 		while ((ritem = g_variant_iter_next_value(&ritems)) != NULL) {
-			gint id = g_variant_get_int32(g_variant_get_child_value(ritem, 0));
+			GVariant * idv = g_variant_get_child_value(ritem, 0);
+			gint id = g_variant_get_int32(idv);
+			g_variant_unref(idv);
 			DbusmenuMenuitem * menuitem = dbusmenu_menuitem_find_id(priv->root, id);
 
 			if (menuitem == NULL) {
@@ -1236,7 +1254,8 @@
 			}
 
 			GVariantIter properties;
-			g_variant_iter_init(&properties, g_variant_get_child_value(ritem, 1));
+			GVariant * propv = g_variant_get_child_value(ritem, 1);
+			g_variant_iter_init(&properties, propv);
 			gchar * property;
 
 			while (g_variant_iter_next(&properties, "s", &property)) {
@@ -1245,16 +1264,23 @@
 				g_free(property);
 			}
 			g_variant_unref(ritem);
+			g_variant_unref(propv);
 		}
+		g_variant_unref(ritemsv);
 
 		GVariantIter items;
-		g_variant_iter_init(&items, g_variant_get_child_value(params, 0));
+		GVariant * itemsv = g_variant_get_child_value(params, 0);
+		g_variant_iter_init(&items, itemsv);
 
 		GVariant * item;
 		while ((item = g_variant_iter_next_value(&items)) != NULL) {
-			gint id = g_variant_get_int32(g_variant_get_child_value(item, 0));
+			GVariant * idv = g_variant_get_child_value(item, 0);
+			gint id = g_variant_get_int32(idv);
+			g_variant_unref(idv);
+
 			GVariantIter properties;
-			g_variant_iter_init(&properties, g_variant_get_child_value(item, 1));
+			GVariant * propv = g_variant_get_child_value(item, 1);
+			g_variant_iter_init(&properties, propv);
 			gchar * property;
 			GVariant * value;
 
@@ -1263,14 +1289,21 @@
 				if (G_LIKELY(g_variant_is_of_type(value, G_VARIANT_TYPE_VARIANT))) {
 					/* Unboxing if needed */
 					internalvalue = g_variant_get_variant(value);
+					g_variant_unref(value);
 				}
 				id_prop_update(proxy, id, property, internalvalue, client);
+				g_variant_unref(internalvalue);
 			}
+			g_variant_unref(propv);
+			g_variant_unref(item);
 		}
+		g_variant_unref(itemsv);
 	} else if (g_strcmp0(signal, "ItemPropertyUpdated") == 0) {
 		gint id; gchar * property; GVariant * value;
 		g_variant_get(params, "(isv)", &id, &property, &value);
 		id_prop_update(proxy, id, property, value, client);
+		g_free(property);
+		g_variant_unref(value);
 	} else if (g_strcmp0(signal, "ItemUpdated") == 0) {
 		gint id;
 		g_variant_get(params, "(i)", &id);
@@ -1594,7 +1627,9 @@
 	}
 
 	/* First verify and figure out what we've got */
-	gint id = g_variant_get_int32(g_variant_get_child_value(layout, 0));
+	GVariant * idv = g_variant_get_child_value(layout, 0);
+	gint id = g_variant_get_int32(idv);
+	g_variant_unref(idv);
 	if (id < 0) {
 		return NULL;
 	}
@@ -1607,8 +1642,10 @@
 
 	/* Some variables */
 	GVariantIter children;
-	g_variant_iter_init(&children, g_variant_get_child_value(layout, 2));
-	GVariant * child;
+	GVariant * childrenv;
+
+	childrenv = g_variant_get_child_value(layout, 2);
+	g_variant_iter_init(&children, childrenv);
 
 	guint position = 0;
 	GList * oldchildren = g_list_copy(dbusmenu_menuitem_get_children(item));
@@ -1616,16 +1653,22 @@
 
 	/* Go through all the XML Nodes and make sure that we have menuitems
 	   to cover those XML nodes. */
+	GVariant * child;
 	while ((child = g_variant_iter_next_value(&children)) != NULL) {
 		/* g_debug("Looking at child: %d", position); */
 		if (g_variant_is_of_type(child, G_VARIANT_TYPE_VARIANT)) {
-			child = g_variant_get_variant(child);
+			GVariant * tmp = g_variant_get_variant(child);
+			g_variant_unref(child);
+			child = tmp;
 		}
 
-		gint childid = g_variant_get_int32(g_variant_get_child_value(child, 0));
+		GVariant * childidv = g_variant_get_child_value(child, 0);
+		gint childid = g_variant_get_int32(childidv);
+		g_variant_unref(childidv);
 		if (childid < 0) {
 			/* Don't increment the position when there isn't a valid
 			   node in the XML tree.  It's probably a comment. */
+			g_variant_unref(child);
 			continue;
 		}
 		DbusmenuMenuitem * childmi = NULL;
@@ -1665,10 +1708,12 @@
 			GVariantIter iter;
 			gchar * prop;
 			GVariant * value;
+			GVariant * child_props;
 
 			/* Set the type first as it can manage the behavior of
 			   all other properties. */
-			g_variant_iter_init(&iter, g_variant_get_child_value(child, 1));
+			child_props = g_variant_get_child_value(child, 1);
+			g_variant_iter_init(&iter, child_props);
 			while (g_variant_iter_next(&iter, "{sv}", &prop, &value)) {
 				if (g_strcmp0(prop, DBUSMENU_MENUITEM_PROP_TYPE) == 0) {
 					dbusmenu_menuitem_property_set_variant(childmi, prop, value);
@@ -1678,15 +1723,17 @@
 			}
 
 			/* Now go through and do all the properties. */
-			g_variant_iter_init(&iter, g_variant_get_child_value(child, 1));
+			g_variant_iter_init(&iter, child_props);
 			while (g_variant_iter_next(&iter, "{sv}", &prop, &value)) {
 				dbusmenu_menuitem_property_set_variant(childmi, prop, value);
 				g_free(prop);
 				g_variant_unref(value);
 			}
+			g_variant_unref(child_props);
 		}
 
 		position++;
+		g_variant_unref(child);
 	}
 
 	/* Remove any children that are no longer used by this version of
@@ -1709,19 +1756,24 @@
 	}
 
 	/* now it's time to recurse down the tree. */
-	g_variant_iter_init(&children, g_variant_get_child_value(layout, 2));
+	g_variant_iter_init(&children, childrenv);
 
 	child = g_variant_iter_next_value(&children);
 	GList * childmis = dbusmenu_menuitem_get_children(item);
 	while (child != NULL && childmis != NULL) {
 		if (g_variant_is_of_type(child, G_VARIANT_TYPE_VARIANT)) {
-			child = g_variant_get_variant(child);
+			GVariant * tmp = g_variant_get_variant(child);
+			g_variant_unref(child);
+			child = tmp;
 		}
 
-		gint xmlid = g_variant_get_int32(g_variant_get_child_value(child, 0));
+		GVariant * xmlidv = g_variant_get_child_value(child, 0);
+		gint xmlid = g_variant_get_int32(xmlidv);
+		g_variant_unref(xmlidv);
 		/* If this isn't a valid menu item we need to move on
 		   until we have one.  This avoids things like comments. */
 		if (xmlid < 0) {
+			g_variant_unref(child);
 			child = g_variant_iter_next_value(&children);
 			continue;
 		}
@@ -1733,10 +1785,13 @@
 		
 		parse_layout_xml(client, child, DBUSMENU_MENUITEM(childmis->data), item, proxy);
 
+		g_variant_unref(child);
 		child = g_variant_iter_next_value(&children);
 		childmis = g_list_next(childmis);
 	}
 
+	g_variant_unref(childrenv);
+
 	if (child != NULL) {
 		g_warning("Sync failed, now we've got extra layout nodes.");
 	}
@@ -1801,6 +1856,7 @@
 
 	GError * error = NULL;
 	GVariant * params = NULL;
+	GVariant * layout = NULL;
 
 	params = g_dbus_proxy_call_finish(G_DBUS_PROXY(proxy), res, &error);
 
@@ -1810,8 +1866,11 @@
 		goto out;
 	}
 
-	guint rev = g_variant_get_uint32(g_variant_get_child_value(params, 0));
-	GVariant * layout = g_variant_get_child_value(params, 1);
+	GVariant * revv = g_variant_get_child_value(params, 0);
+	guint rev = g_variant_get_uint32(revv);
+	g_variant_unref(revv);
+
+	layout = g_variant_get_child_value(params, 1);
 
 	guint parseable = parse_layout(client, layout);
 
@@ -1839,6 +1898,10 @@
 		priv->layoutcall = NULL;
 	}
 
+	if (layout != NULL) {
+		g_variant_unref(layout);
+	}
+
 	if (params != NULL) {
 		g_variant_unref(params);
 	}
 
=== modified file 'libdbusmenu-glib/dbus-menu.xml'
--- libdbusmenu-glib/dbus-menu.xml	2011-03-03 19:48:56 +0000
+++ libdbusmenu-glib/dbus-menu.xml	2011-03-16 19:16:36 +0000
@@ -294,6 +294,8 @@
 
 			@li "clicked"
 			@li "hovered"
+			@li "opened"
+			@li "closed"
 
 			Vendor specific events can be added by prefixing them with "x-<vendor>-"
 			]]></dox:d>
 
=== modified file 'libdbusmenu-glib/enum-types.c'
--- libdbusmenu-glib/enum-types.c	2011-02-24 21:06:19 +0000
+++ libdbusmenu-glib/enum-types.c	2011-03-16 19:16:36 +0000
@@ -30,7 +30,7 @@
 
 #include "enum-types.h"
 
-#include "./types.h"
+#include "types.h"
 /**
 	dbusmenu_text_direction_get_type:
 
 
=== modified file 'libdbusmenu-glib/enum-types.h'
--- libdbusmenu-glib/enum-types.h	2011-02-24 21:06:19 +0000
+++ libdbusmenu-glib/enum-types.h	2011-03-16 19:16:36 +0000
@@ -36,10 +36,13 @@
 G_BEGIN_DECLS
 
 /* Enumerations from file: "./types.h" */
-#include "./types.h"
+#include "types.h"
+
+
 GType dbusmenu_text_direction_get_type (void) G_GNUC_CONST;
 const gchar * dbusmenu_text_direction_get_nick (DbusmenuTextDirection value) G_GNUC_CONST;
 DbusmenuTextDirection dbusmenu_text_direction_get_value_from_nick (const gchar * nick) G_GNUC_CONST;
+
 /**
 	DBUSMENU_TYPE_TEXT_DIRECTION:
 
@@ -48,9 +51,11 @@
 */
 #define DBUSMENU_TYPE_TEXT_DIRECTION (dbusmenu_text_direction_get_type())
 
+
 GType dbusmenu_status_get_type (void) G_GNUC_CONST;
 const gchar * dbusmenu_status_get_nick (DbusmenuStatus value) G_GNUC_CONST;
 DbusmenuStatus dbusmenu_status_get_value_from_nick (const gchar * nick) G_GNUC_CONST;
+
 /**
 	DBUSMENU_TYPE_STATUS:
 
 
=== modified file 'libdbusmenu-glib/menuitem.c'
--- libdbusmenu-glib/menuitem.c	2011-03-07 19:56:53 +0000
+++ libdbusmenu-glib/menuitem.c	2011-03-16 19:16:36 +0000
@@ -430,7 +430,7 @@
 static void
 handle_event (DbusmenuMenuitem * mi, const gchar * name, GVariant * value, guint timestamp)
 {
-	if (g_strcmp0(name, "clicked") == 0) {
+	if (g_strcmp0(name, DBUSMENU_MENUITEM_EVENT_ACTIVATED) == 0) {
 		g_signal_emit(G_OBJECT(mi), signals[ITEM_ACTIVATED], 0, timestamp, TRUE);
 	}
 
 
=== modified file 'libdbusmenu-glib/menuitem.h'
--- libdbusmenu-glib/menuitem.h	2011-02-24 16:52:10 +0000
+++ libdbusmenu-glib/menuitem.h	2011-03-16 19:16:36 +0000
@@ -267,6 +267,32 @@
  */
 #define DBUSMENU_MENUITEM_CHILD_DISPLAY_SUBMENU      "submenu"
 
+/**
+ * DBUSMENU_MENUITEM_EVENT_ACTIVATED:
+ *
+ * String for the event identifier when a menu item is clicked
+ * on by the user.
+ */
+#define DBUSMENU_MENUITEM_EVENT_ACTIVATED            "clicked"
+
+/**
+ * DBUSMENU_MENUITEM_EVENT_OPENED:
+ *
+ * String for the event identifier when a menu is opened and
+ * displayed to the user.  Only valid for items that contain
+ * submenus.
+ */
+#define DBUSMENU_MENUITEM_EVENT_OPENED               "opened"
+
+/**
+ * DBUSMENU_MENUITEM_EVENT_CLOSED:
+ *
+ * String for the event identifier when a menu is closed and
+ * displayed to the user.  Only valid for items that contain
+ * submenus.
+ */
+#define DBUSMENU_MENUITEM_EVENT_CLOSED               "closed"
+
 typedef struct _DbusmenuMenuitemPrivate DbusmenuMenuitemPrivate;
 
 /**
 
=== modified file 'libdbusmenu-gtk/client.c'
--- libdbusmenu-gtk/client.c	2011-03-10 16:27:52 +0000
+++ libdbusmenu-gtk/client.c	2011-03-16 19:16:36 +0000
@@ -458,7 +458,7 @@
 {
 	if (gtk_menu_item_get_submenu(gmi) == NULL) {
 		GVariant * variant = g_variant_new("i", 0);
-		dbusmenu_menuitem_handle_event(mi, "clicked", variant, gtk_get_current_event_time());
+		dbusmenu_menuitem_handle_event(mi, DBUSMENU_MENUITEM_EVENT_ACTIVATED, variant, gtk_get_current_event_time());
 	} else {
 		/* TODO: We need to stop the display of the submenu
 		         until this callback returns. */
@@ -467,6 +467,15 @@
 	return TRUE;
 }
 
+static void
+submenu_notify_visible_cb (GtkWidget * menu, GParamSpec * pspec, DbusmenuMenuitem * mi)
+{
+       if (gtk_widget_get_visible (menu))
+               dbusmenu_menuitem_handle_event(mi, DBUSMENU_MENUITEM_EVENT_OPENED, NULL, gtk_get_current_event_time());
+       else
+               dbusmenu_menuitem_handle_event(mi, DBUSMENU_MENUITEM_EVENT_CLOSED, NULL, gtk_get_current_event_time());
+}
+
 /* Process the visible property */
 static void
 process_visible (DbusmenuMenuitem * mi, GtkMenuItem * gmi, GVariant * value)
@@ -740,11 +749,12 @@
 
 		GtkMenuItem * parent = dbusmenu_gtkclient_menuitem_get(gtkclient, mi);
 		gtk_menu_item_set_submenu(parent, GTK_WIDGET(menu));
+
+		g_signal_connect(menu, "notify::visible", G_CALLBACK(submenu_notify_visible_cb), mi);
 	} 
 
 	GtkMenuItem * childmi  = dbusmenu_gtkclient_menuitem_get(gtkclient, child);
 	gtk_menu_shell_insert(GTK_MENU_SHELL(menu), GTK_WIDGET(childmi), position);
-	gtk_widget_show(GTK_WIDGET(menu));
 	
 	return;
 }
 
=== modified file 'libdbusmenu-gtk/dbusmenu-gtk-0.4.pc.in'
--- libdbusmenu-gtk/dbusmenu-gtk-0.4.pc.in	2010-12-08 15:27:48 +0000
+++ libdbusmenu-gtk/dbusmenu-gtk-0.4.pc.in	2011-03-16 19:16:36 +0000
@@ -5,7 +5,7 @@
 includedir=@includedir@
 
 Cflags: -I${includedir}/libdbusmenu-0.4
-Requires: dbusmenu-glib-0.4
+Requires: dbusmenu-glib-0.4 gdk-pixbuf-2.0 gtk+-2.0
 Libs: -L${libdir} -ldbusmenu-gtk
 
 Name: libdbusmenu-gtk
 
=== modified file 'libdbusmenu-gtk/dbusmenu-gtk3-0.4.pc.in'
--- libdbusmenu-gtk/dbusmenu-gtk3-0.4.pc.in	2010-12-08 15:27:48 +0000
+++ libdbusmenu-gtk/dbusmenu-gtk3-0.4.pc.in	2011-03-16 19:16:36 +0000
@@ -5,7 +5,7 @@
 includedir=@includedir@
 
 Cflags: -I${includedir}/libdbusmenu-0.4
-Requires: dbusmenu-glib-0.4
+Requires: dbusmenu-glib-0.4 gdk-pixbuf-2.0 gtk+-3.0
 Libs: -L${libdir} -ldbusmenu-gtk3
 
 Name: libdbusmenu-gtk3
 
=== modified file 'libdbusmenu-gtk/parser.c'
--- libdbusmenu-gtk/parser.c	2011-03-10 17:05:16 +0000
+++ libdbusmenu-gtk/parser.c	2011-03-16 19:16:36 +0000
@@ -69,6 +69,9 @@
 static void           child_added_cb           (GtkContainer *      menu,
                                                 GtkWidget *         widget,
                                                 gpointer            data);
+static void           child_removed_cb         (GtkContainer *      menu,
+                                                GtkWidget *         widget,
+                                                gpointer            data);
 static void           theme_changed_cb         (GtkIconTheme *      theme,
                                                 gpointer            data);
 static void           item_activated           (DbusmenuMenuitem *  item,
@@ -98,15 +101,25 @@
 DbusmenuMenuitem *
 dbusmenu_gtk_parse_menu_structure (GtkWidget * widget)
 {
-  g_return_val_if_fail(GTK_IS_MENU_ITEM(widget) || GTK_IS_MENU_SHELL(widget), NULL);
-
-  RecurseContext recurse = {0};
-
-  recurse.toplevel = gtk_widget_get_toplevel(widget);
-
-  parse_menu_structure_helper(widget, &recurse);
-
-  return recurse.parent;
+	g_return_val_if_fail(GTK_IS_MENU_ITEM(widget) || GTK_IS_MENU_SHELL(widget), NULL);
+
+	DbusmenuMenuitem * returnval = NULL;
+	gpointer data = g_object_get_data(G_OBJECT(widget), CACHED_MENUITEM);
+
+	if (data == NULL) {
+		RecurseContext recurse = {0};
+
+		recurse.toplevel = gtk_widget_get_toplevel(widget);
+
+		parse_menu_structure_helper(widget, &recurse);
+
+		returnval = recurse.parent;
+	} else {
+		returnval = DBUSMENU_MENUITEM(data);
+		g_object_ref(G_OBJECT(returnval));
+	}
+
+	return returnval;
 }
 
 /**
@@ -124,7 +137,9 @@
 DbusmenuMenuitem *
 dbusmenu_gtk_parse_get_cached_item (GtkWidget * widget)
 {
-	g_return_val_if_fail(GTK_IS_MENU_ITEM(widget), NULL);
+	if (!GTK_IS_MENU_ITEM(widget)) {
+		return NULL;
+	}
 	return DBUSMENU_MENUITEM(g_object_get_data(G_OBJECT(widget), CACHED_MENUITEM));
 }
 
@@ -160,6 +175,8 @@
 	if (pdata != NULL && pdata->shell != NULL) {
 		g_signal_handlers_disconnect_matched(pdata->shell, (GSignalMatchType)G_SIGNAL_MATCH_FUNC,
 						     0, 0, NULL, G_CALLBACK(child_added_cb), NULL);
+		g_signal_handlers_disconnect_matched(pdata->shell, (GSignalMatchType)G_SIGNAL_MATCH_FUNC,
+						     0, 0, NULL, G_CALLBACK(child_removed_cb), NULL);
 		g_object_remove_weak_pointer(G_OBJECT(pdata->shell), (gpointer*)&pdata->shell);
 	}
 
@@ -246,7 +263,6 @@
 static void
 parse_menu_structure_helper (GtkWidget * widget, RecurseContext * recurse)
 {
-
 	/* If this is a shell, then let's handle the items in it. */
 	if (GTK_IS_MENU_SHELL (widget)) {
 		/* Okay, this is a little janky and all.. but some applications update some
@@ -282,6 +298,10 @@
 				          "child-added",
 				          G_CALLBACK (child_added_cb),
 				          recurse->parent);
+			g_signal_connect (G_OBJECT (widget),
+				          "child-removed",
+				          G_CALLBACK (child_removed_cb),
+				          recurse->parent);
 			g_object_add_weak_pointer(G_OBJECT (widget), (gpointer*)&pdata->shell);
 		}
 
@@ -371,14 +391,20 @@
            which we don't. */
 	gchar * sanitized = NULL;
 	GError * error = NULL;
+
+	if (label == NULL) {
+		return NULL;
+	}
+
 	if (pango_parse_markup (label, -1, 0, NULL, &sanitized, NULL, &error)) {
 		return sanitized;
 	}
-	else {
+
+	if (error != NULL) {
 		g_warning ("Could not parse '%s': %s", label, error->message);
 		g_error_free (error);
-		return g_strdup (label);
 	}
+	return g_strdup (label);
 }
 
 static gchar *
@@ -533,6 +559,10 @@
                                 "child-added",
                                 G_CALLBACK (child_added_cb),
                                 mi);
+              g_signal_connect (G_OBJECT (submenu),
+                                "child-removed",
+                                G_CALLBACK (child_removed_cb),
+                                mi);
               g_object_add_weak_pointer(G_OBJECT(submenu), (gpointer*)&pdata->shell);
             }
 
@@ -625,6 +655,9 @@
 
   if (image != NULL && should_show_image (image)) {
     switch (gtk_image_get_storage_type (image)) {
+    case GTK_IMAGE_EMPTY:
+      break;
+
     case GTK_IMAGE_PIXBUF:
       pixbuf = g_object_ref (gtk_image_get_pixbuf (image));
       break;
@@ -940,6 +973,28 @@
 	parse_menu_structure_helper(widget, &recurse);
 }
 
+/* A child item was added to a menu we're watching.  Let's try to integrate it. */
+static void
+child_removed_cb (GtkContainer *menu, GtkWidget *widget, gpointer data)
+{
+	gpointer pmi = g_object_get_data(G_OBJECT(widget), CACHED_MENUITEM);
+	if (pmi == NULL) {
+		return;
+	}
+
+	DbusmenuMenuitem * child = DBUSMENU_MENUITEM(pmi);
+
+	pmi = g_object_get_data(G_OBJECT(menu), CACHED_MENUITEM);
+	if (pmi == NULL) {
+		return;
+	}
+
+	DbusmenuMenuitem * parent = DBUSMENU_MENUITEM(pmi);
+
+	dbusmenu_menuitem_child_delete(parent, child);
+	return;
+}
+
 static void
 theme_changed_cb (GtkIconTheme *theme, gpointer data)
 {