Merge lp:~dbusmenu-team/libdbusmenu/ubuntu into lp:~ubuntu-desktop/libdbusmenu/ubuntu

Proposed by Ted Gould
Status: Merged
Merged at revision: 97
Proposed branch: lp:~dbusmenu-team/libdbusmenu/ubuntu
Merge into: lp:~ubuntu-desktop/libdbusmenu/ubuntu
Diff against target: 245 lines (+70/-18)
8 files modified
configure (+11/-11)
configure.ac (+3/-3)
debian/changelog (+9/-0)
debian/control (+4/-1)
debian/rules (+1/-0)
docs/libdbusmenu-glib/reference/version.xml (+1/-1)
docs/libdbusmenu-gtk/reference/version.xml (+1/-1)
libdbusmenu-glib/server.c (+40/-1)
To merge this branch: bzr merge lp:~dbusmenu-team/libdbusmenu/ubuntu
Reviewer Review Type Date Requested Status
Ken VanDine Pending
Review via email: mp+35556@code.launchpad.net

Description of the change

0.3.14

To post a comment you must log in.
lp:~dbusmenu-team/libdbusmenu/ubuntu updated
97. By Ken VanDine

releasing version 0.3.14-0ubuntu1

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'configure'
--- configure 2010-09-09 14:42:16 +0000
+++ configure 2010-09-15 16:46:41 +0000
@@ -1,6 +1,6 @@
1#! /bin/sh1#! /bin/sh
2# Guess values for system-dependent variables and create Makefiles.2# Guess values for system-dependent variables and create Makefiles.
3# Generated by GNU Autoconf 2.67 for libdbusmenu 0.3.13.3# Generated by GNU Autoconf 2.67 for libdbusmenu 0.3.14.
4#4#
5# Report bugs to <ted@canonical.com>.5# Report bugs to <ted@canonical.com>.
6#6#
@@ -703,8 +703,8 @@
703# Identity of this package.703# Identity of this package.
704PACKAGE_NAME='libdbusmenu'704PACKAGE_NAME='libdbusmenu'
705PACKAGE_TARNAME='libdbusmenu'705PACKAGE_TARNAME='libdbusmenu'
706PACKAGE_VERSION='0.3.13'706PACKAGE_VERSION='0.3.14'
707PACKAGE_STRING='libdbusmenu 0.3.13'707PACKAGE_STRING='libdbusmenu 0.3.14'
708PACKAGE_BUGREPORT='ted@canonical.com'708PACKAGE_BUGREPORT='ted@canonical.com'
709PACKAGE_URL=''709PACKAGE_URL=''
710710
@@ -1533,7 +1533,7 @@
1533 # Omit some internal or obsolete options to make the list less imposing.1533 # Omit some internal or obsolete options to make the list less imposing.
1534 # This message is too long to be a string in the A/UX 3.1 sh.1534 # This message is too long to be a string in the A/UX 3.1 sh.
1535 cat <<_ACEOF1535 cat <<_ACEOF
1536\`configure' configures libdbusmenu 0.3.13 to adapt to many kinds of systems.1536\`configure' configures libdbusmenu 0.3.14 to adapt to many kinds of systems.
15371537
1538Usage: $0 [OPTION]... [VAR=VALUE]...1538Usage: $0 [OPTION]... [VAR=VALUE]...
15391539
@@ -1603,7 +1603,7 @@
16031603
1604if test -n "$ac_init_help"; then1604if test -n "$ac_init_help"; then
1605 case $ac_init_help in1605 case $ac_init_help in
1606 short | recursive ) echo "Configuration of libdbusmenu 0.3.13:";;1606 short | recursive ) echo "Configuration of libdbusmenu 0.3.14:";;
1607 esac1607 esac
1608 cat <<\_ACEOF1608 cat <<\_ACEOF
16091609
@@ -1741,7 +1741,7 @@
1741test -n "$ac_init_help" && exit $ac_status1741test -n "$ac_init_help" && exit $ac_status
1742if $ac_init_version; then1742if $ac_init_version; then
1743 cat <<\_ACEOF1743 cat <<\_ACEOF
1744libdbusmenu configure 0.3.131744libdbusmenu configure 0.3.14
1745generated by GNU Autoconf 2.671745generated by GNU Autoconf 2.67
17461746
1747Copyright (C) 2010 Free Software Foundation, Inc.1747Copyright (C) 2010 Free Software Foundation, Inc.
@@ -2112,7 +2112,7 @@
2112This file contains any messages produced by compilers while2112This file contains any messages produced by compilers while
2113running configure, to aid debugging if configure makes a mistake.2113running configure, to aid debugging if configure makes a mistake.
21142114
2115It was created by libdbusmenu $as_me 0.3.13, which was2115It was created by libdbusmenu $as_me 0.3.14, which was
2116generated by GNU Autoconf 2.67. Invocation command line was2116generated by GNU Autoconf 2.67. Invocation command line was
21172117
2118 $ $0 $@2118 $ $0 $@
@@ -2933,7 +2933,7 @@
29332933
2934# Define the identity of the package.2934# Define the identity of the package.
2935 PACKAGE=libdbusmenu2935 PACKAGE=libdbusmenu
2936 VERSION=0.3.132936 VERSION=0.3.14
29372937
29382938
2939# Some tools Automake needs.2939# Some tools Automake needs.
@@ -13065,7 +13065,7 @@
13065###########################13065###########################
1306613066
13067LIBDBUSMENU_CURRENT=113067LIBDBUSMENU_CURRENT=1
13068LIBDBUSMENU_REVISION=1513068LIBDBUSMENU_REVISION=16
13069LIBDBUSMENU_AGE=013069LIBDBUSMENU_AGE=0
1307013070
1307113071
@@ -14379,7 +14379,7 @@
14379# report actual input values of CONFIG_FILES etc. instead of their14379# report actual input values of CONFIG_FILES etc. instead of their
14380# values after options handling.14380# values after options handling.
14381ac_log="14381ac_log="
14382This file was extended by libdbusmenu $as_me 0.3.13, which was14382This file was extended by libdbusmenu $as_me 0.3.14, which was
14383generated by GNU Autoconf 2.67. Invocation command line was14383generated by GNU Autoconf 2.67. Invocation command line was
1438414384
14385 CONFIG_FILES = $CONFIG_FILES14385 CONFIG_FILES = $CONFIG_FILES
@@ -14445,7 +14445,7 @@
14445cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=114445cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1
14446ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"14446ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`"
14447ac_cs_version="\\14447ac_cs_version="\\
14448libdbusmenu config.status 0.3.1314448libdbusmenu config.status 0.3.14
14449configured by $0, generated by GNU Autoconf 2.67,14449configured by $0, generated by GNU Autoconf 2.67,
14450 with options \\"\$ac_cs_config\\"14450 with options \\"\$ac_cs_config\\"
1445114451
1445214452
=== modified file 'configure.ac'
--- configure.ac 2010-09-09 14:42:16 +0000
+++ configure.ac 2010-09-15 16:46:41 +0000
@@ -1,11 +1,11 @@
11
2AC_INIT(libdbusmenu, 0.3.13, ted@canonical.com)2AC_INIT(libdbusmenu, 0.3.14, ted@canonical.com)
3AC_COPYRIGHT([Copyright 2009,2010 Canonical])3AC_COPYRIGHT([Copyright 2009,2010 Canonical])
44
5AC_PREREQ(2.62)5AC_PREREQ(2.62)
66
7AM_CONFIG_HEADER(config.h)7AM_CONFIG_HEADER(config.h)
8AM_INIT_AUTOMAKE(libdbusmenu, 0.3.13, [-Wno-portability])8AM_INIT_AUTOMAKE(libdbusmenu, 0.3.14, [-Wno-portability])
99
10AM_MAINTAINER_MODE10AM_MAINTAINER_MODE
1111
@@ -99,7 +99,7 @@
99###########################99###########################
100100
101LIBDBUSMENU_CURRENT=1101LIBDBUSMENU_CURRENT=1
102LIBDBUSMENU_REVISION=15102LIBDBUSMENU_REVISION=16
103LIBDBUSMENU_AGE=0103LIBDBUSMENU_AGE=0
104104
105AC_SUBST(LIBDBUSMENU_CURRENT)105AC_SUBST(LIBDBUSMENU_CURRENT)
106106
=== modified file 'debian/changelog'
--- debian/changelog 2010-09-09 16:34:05 +0000
+++ debian/changelog 2010-09-15 16:46:41 +0000
@@ -1,3 +1,12 @@
1libdbusmenu (0.3.14-0ubuntu1~ppa1) maverick; urgency=low
2
3 * New upstream release.
4 * Fixing a memory leak by unref'ing a hashtable
5 * Making a callback for the event dbus function happen off
6 of the mainloop so it returns a response. (LP: #636756)
7
8 -- Ted Gould <ted@ubuntu.com> Wed, 15 Sep 2010 11:36:09 -0500
9
1libdbusmenu (0.3.13-0ubuntu1) maverick; urgency=low10libdbusmenu (0.3.13-0ubuntu1) maverick; urgency=low
211
3 * New upstream release.12 * New upstream release.
413
=== modified file 'debian/control'
--- debian/control 2010-09-09 16:34:05 +0000
+++ debian/control 2010-09-15 16:46:41 +0000
@@ -20,7 +20,10 @@
20 gir1.0-glib-2.0,20 gir1.0-glib-2.0,
21 gir1.0-gtk-2.0,21 gir1.0-gtk-2.0,
22 libx11-dev (>= 1.3), 22 libx11-dev (>= 1.3),
23 valac23 valac,
24# Check dependencies
25 xvfb,
26 dbus-test-runner
24Standards-Version: 3.9.127Standards-Version: 3.9.1
25Homepage: https://launchpad.net/dbusmenu28Homepage: https://launchpad.net/dbusmenu
26Vcs-Bzr: https://code.launchpad.net/~dbusmenu-team/dbusmenu/ubuntu29Vcs-Bzr: https://code.launchpad.net/~dbusmenu-team/dbusmenu/ubuntu
2730
=== modified file 'debian/rules'
--- debian/rules 2010-09-09 16:34:05 +0000
+++ debian/rules 2010-09-15 16:46:41 +0000
@@ -3,6 +3,7 @@
3include /usr/share/cdbs/1/rules/debhelper.mk3include /usr/share/cdbs/1/rules/debhelper.mk
4include /usr/share/cdbs/1/class/gnome.mk4include /usr/share/cdbs/1/class/gnome.mk
55
6DEB_MAKE_CHECK_TARGET := check
6DEB_CONFIGURE_EXTRA_FLAGS += --disable-scrollkeeper --enable-gtk-doc7DEB_CONFIGURE_EXTRA_FLAGS += --disable-scrollkeeper --enable-gtk-doc
7LDFLAGS += -Wl,-z,defs -Wl,--as-needed8LDFLAGS += -Wl,-z,defs -Wl,--as-needed
89
910
=== modified file 'docs/libdbusmenu-glib/reference/version.xml'
--- docs/libdbusmenu-glib/reference/version.xml 2010-09-09 14:42:16 +0000
+++ docs/libdbusmenu-glib/reference/version.xml 2010-09-15 16:46:41 +0000
@@ -1,1 +1,1 @@
10.3.1310.3.14
22
=== modified file 'docs/libdbusmenu-gtk/reference/version.xml'
--- docs/libdbusmenu-gtk/reference/version.xml 2010-09-09 14:42:16 +0000
+++ docs/libdbusmenu-gtk/reference/version.xml 2010-09-15 16:46:41 +0000
@@ -1,1 +1,1 @@
10.3.1310.3.14
22
=== modified file 'libdbusmenu-glib/server.c'
--- libdbusmenu-glib/server.c 2010-08-25 18:19:05 +0000
+++ libdbusmenu-glib/server.c 2010-09-15 16:46:41 +0000
@@ -633,6 +633,10 @@
633 _gvalue_array_append_hashtable(item, dict);633 _gvalue_array_append_hashtable(item, dict);
634634
635 g_ptr_array_add(output, item);635 g_ptr_array_add(output, item);
636
637 g_hash_table_unref(dict);
638
639 return;
636}640}
637641
638static gboolean642static gboolean
@@ -659,6 +663,33 @@
659 return TRUE;663 return TRUE;
660}664}
661665
666/* Structure for holding the event data for the idle function
667 to pick it up. */
668typedef struct _idle_event_t idle_event_t;
669struct _idle_event_t {
670 DbusmenuMenuitem * mi;
671 gchar * eventid;
672 GValue data;
673 guint timestamp;
674};
675
676/* A handler for else where in the main loop so that the dbusmenu
677 event response doesn't get blocked */
678static gboolean
679event_local_handler (gpointer user_data)
680{
681 idle_event_t * data = (idle_event_t *)user_data;
682
683 dbusmenu_menuitem_handle_event(data->mi, data->eventid, &data->data, data->timestamp);
684
685 g_object_unref(data->mi);
686 g_free(data->eventid);
687 g_value_unset(&data->data);
688 g_free(data);
689 return FALSE;
690}
691
692/* Handles the even coming off of DBus */
662static gboolean693static gboolean
663_dbusmenu_server_event (DbusmenuServer * server, gint id, gchar * eventid, GValue * data, guint timestamp, GError ** error)694_dbusmenu_server_event (DbusmenuServer * server, gint id, gchar * eventid, GValue * data, guint timestamp, GError ** error)
664{695{
@@ -676,7 +707,15 @@
676 return FALSE;707 return FALSE;
677 }708 }
678709
679 dbusmenu_menuitem_handle_event(mi, eventid, data, timestamp);710 idle_event_t * event_data = g_new0(idle_event_t, 1);
711 event_data->mi = mi;
712 g_object_ref(event_data->mi);
713 event_data->eventid = g_strdup(eventid);
714 event_data->timestamp = timestamp;
715 g_value_init(&(event_data->data), G_VALUE_TYPE(data));
716 g_value_copy(data, &(event_data->data));
717
718 g_timeout_add(0, event_local_handler, event_data);
680 return TRUE;719 return TRUE;
681}720}
682721

Subscribers

People subscribed via source and target branches

to all changes: