Code review comment for lp:~dbuliga/charm-helpers/charm-helpers

Greetings Denis,

Thanks for this massive contribution to charm-helpers! I've taken some time to look this over and I really like your approach to abstracting the distro's nuances. I'm pretty happy with how you've done this, and would ideally like to see unit tests bundled with a change this large.

However that being said, this looks like some great work. I additionally like how you've maintained backwords compat while this settles out and starts to land. Approving this MP today would potentially disrupt a lot of work going on with the rest of the ecosystem, so I'll leave my +1 and have someone else come by to take a look at the merge.

Thanks again for being patient and making such a great contribution! We really appreciate it.

If you have any questions/comments/concerns about the review contact us in #juju on irc.freenode.net or email the mailing list <email address hidden>, or ask a question tagged with "juju" on http://askubuntu.com.