Code review comment for lp:~dbarth/zeitgeist-extensions/fts-cjk-support

Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

The condition os.environ['XAPIAN_CJK_NGRAM'] == 1 will always be false, use "1". But maybe we really want to check != None since I thin I recall Olly mentioning that Xapian activates CJK if the envvar is set (disregarding value).

Stylistically we use double quotes " and not single quotes ' for strings.

review: Needs Fixing

« Back to merge proposal