Code review comment for lp:~dbarth/indicator-me/with-about-me

Revision history for this message
Cody Russell (bratsche) wrote :

In get_pixels_per_em(), the g_return_val_if_fail() parameters are reversed, so this needs to be fixed.

Small thing.. but in about_me_menu_item_class_init(), don't create a GtkObjectClass variable. You can do g_type_class_add_private() using gobject_class.

And lastly, is there any chance at all I could convince you to have your text editor use spaces for indenting instead of tabs? The indentation looks really weird in the merge request and also in my emacs. :)

review: Needs Fixing

« Back to merge proposal