Merge lp:~davidmhewitt/wingpanel/fix-empty-indicator into lp:~wingpanel-devs/wingpanel/trunk
Proposed by
David Hewitt
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | David Hewitt | ||||
Approved revision: | 175 | ||||
Merged at revision: | 175 | ||||
Proposed branch: | lp:~davidmhewitt/wingpanel/fix-empty-indicator | ||||
Merge into: | lp:~wingpanel-devs/wingpanel/trunk | ||||
Diff against target: |
23 lines (+5/-3) 1 file modified
src/Widgets/IndicatorMenuBar.vala (+5/-3) |
||||
To merge this branch: | bzr merge lp:~davidmhewitt/wingpanel/fix-empty-indicator | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Kirill Romanov (community) | test | Approve | |
WingPanel Devs | Pending | ||
Review via email:
|
Commit message
Prevent adding an indicator with the same code_name twice
Description of the change
Was experiencing the linked bug with the Slack indicator. There would be an empty space to the right of it which opened an empty popover when you clicked it.
It seems like two Indicator objects are created for some of the Ayatana indicators. To prevent them both being added, we now compare the code name instead of just the object reference to prevent the same indicator being added twice.
To post a comment you must log in.
Hey, they were after the iterate before and we moved it up because this was a issue in some case. Don't remember why.
I think the core issue with this problem is that the ayatana indicator is loaded. It loads again all the ayatana indicators and register them. So while it iterates over the get_indicators () the ayatana register new indicators to the list and so it iterates over the new ones in the forach and the indicator_added signal is triggered.
So I think the get_indicators of the manager should maybe return something not modifiable.