Code review comment for lp:~davidc3/unity-scope-github/use-mimetype-icons

Revision history for this message
James Henstridge (jamesh) wrote :

Rather than searching for icons in the same directory as the "text-x-python" one, why not have a dictionary mapping language => icon_name and cache the lookup_icon result?

While it might be expensive to perform the lookup on every search, it should be okay if you amortise the result over many requests (and will probably be faster than the stat system call os.path.isfile() does).

« Back to merge proposal