Code review comment for lp:~davidc3/unity-scope-github/use-mimetype-icons

Revision history for this message
Michal Hruby (mhr3) wrote :

78 + if os.path.isfile("%s/%s.%s" % (THEME_PATH, potential_icon, ICON_EXTENSION)):

This is still a fstat() for each result, and that's expensive. How about just having a static dict that would map the languages to a mimetype(/content type), doing a lookup in that dict and using g_content_type_get_icon().

review: Needs Fixing

« Back to merge proposal