Code review comment for lp:~davidagraf/zorba/trace_without_debug_info

Revision history for this message
David Graf (davidagraf) wrote :

> David:
>
> 1. I agree, the duplication of code to output attributes is not pretty. I
> don't think it would be too difficult to add support for directly serializing
> attributes to the serializer itself. And it wouldn't have to be changed in
> every emitter, only whichever emitter is used for basic XML serialization.
>
Hello Chris
The only solution I see is to pass an additional parameter to emitter::emit_item to tell the function if it should throw an error or not if an attribute is passed. But this implies changing the emit_item function of all emitters. Do you see a nicer solution?

« Back to merge proposal