Merge lp:~david.gabor.bodor/sakura/config-file-option into lp:~dabisu/sakura/sakura

Proposed by Dávid Gábor Bodor
Status: Merged
Merge reported by: David Gómez
Merged at revision: not available
Proposed branch: lp:~david.gabor.bodor/sakura/config-file-option
Merge into: lp:~dabisu/sakura/sakura
Diff against target: 55 lines (+8/-4)
4 files modified
CMakeLists.txt (+1/-1)
po/sakura.pot (+1/-1)
sakura.pod (+5/-0)
src/sakura.c (+1/-2)
To merge this branch: bzr merge lp:~david.gabor.bodor/sakura/config-file-option
Reviewer Review Type Date Requested Status
David Gómez Approve
Review via email: mp+95609@code.launchpad.net

Description of the change

This patch is long overdue, my sincere apologies for that.

I made the config-file option use the sakura config dir as a base, also, updated the man pages to include the new option. (Please check them, I'm not a native english speaker).
Also removed a printf I accidentally left in for debug purposes.

This revision already includes the fix for the linker error concerning libm.so

To post a comment you must log in.
Revision history for this message
David Gómez (dabisu) wrote :

Thanks Bodor, I've merged the latest changes.

Revision history for this message
David Gómez (dabisu) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'CMakeLists.txt'
--- CMakeLists.txt 2012-02-27 13:39:19 +0000
+++ CMakeLists.txt 2012-03-02 16:32:23 +0000
@@ -43,7 +43,7 @@
4343
44INCLUDE_DIRECTORIES (. ${GTK_INCLUDE_DIRS} ${VTE_INCLUDE_DIRS})44INCLUDE_DIRECTORIES (. ${GTK_INCLUDE_DIRS} ${VTE_INCLUDE_DIRS})
45LINK_DIRECTORIES (${GTK_LIBRARY_DIRS} ${VTE_LIBRARY_DIRS})45LINK_DIRECTORIES (${GTK_LIBRARY_DIRS} ${VTE_LIBRARY_DIRS})
46LINK_LIBRARIES (${GTK_LIBRARIES} ${VTE_LIBRARIES})46LINK_LIBRARIES (${GTK_LIBRARIES} ${VTE_LIBRARIES} m)
47ADD_EXECUTABLE (sakura src/sakura.c)47ADD_EXECUTABLE (sakura src/sakura.c)
48ADD_DEPENDENCIES (sakura src/sakura.c src/sakura.h)48ADD_DEPENDENCIES (sakura src/sakura.c src/sakura.h)
4949
5050
=== modified file 'po/sakura.pot'
--- po/sakura.pot 2012-02-27 13:38:29 +0000
+++ po/sakura.pot 2012-03-02 16:32:23 +0000
@@ -8,7 +8,7 @@
8msgstr ""8msgstr ""
9"Project-Id-Version: PACKAGE VERSION\n"9"Project-Id-Version: PACKAGE VERSION\n"
10"Report-Msgid-Bugs-To: \n"10"Report-Msgid-Bugs-To: \n"
11"POT-Creation-Date: 2012-02-27 14:37+0100\n"11"POT-Creation-Date: 2012-03-02 17:21+0100\n"
12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"12"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"13"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
14"Language-Team: LANGUAGE <LL@li.org>\n"14"Language-Team: LANGUAGE <LL@li.org>\n"
1515
=== modified file 'sakura.pod'
--- sakura.pod 2010-10-19 14:27:36 +0000
+++ sakura.pod 2012-03-02 16:32:23 +0000
@@ -78,6 +78,11 @@
7878
79X display to use79X display to use
8080
81=item B<--config-file=FILENAME>
82
83Use alternate configurtation file. Path is relative to the sakura config dir.
84(Example: ~/.config/sakura/FILENAME).
85
81=back86=back
8287
83=head1 GTK+ OPTIONS88=head1 GTK+ OPTIONS
8489
=== modified file 'src/sakura.c'
--- src/sakura.c 2012-02-27 13:35:40 +0000
+++ src/sakura.c 2012-03-02 16:32:23 +0000
@@ -1589,8 +1589,7 @@
1589 if( ! g_file_test( configdir, G_FILE_TEST_EXISTS) )1589 if( ! g_file_test( configdir, G_FILE_TEST_EXISTS) )
1590 g_mkdir( configdir, 0755 );1590 g_mkdir( configdir, 0755 );
1591 if (option_config_file) {1591 if (option_config_file) {
1592 sakura.configfile=option_config_file;1592 sakura.configfile=g_build_filename(configdir, option_config_file, NULL);
1593 printf("The config file is: %s", option_config_file);
1594 } else {1593 } else {
1595 /* Use more standard-conforming path for config files, if available. */1594 /* Use more standard-conforming path for config files, if available. */
1596 sakura.configfile=g_build_filename(configdir, DEFAULT_CONFIGFILE, NULL);1595 sakura.configfile=g_build_filename(configdir, DEFAULT_CONFIGFILE, NULL);

Subscribers

People subscribed via source and target branches