Code review comment for lp:~david-schwarz/lava-dispatcher/ssh_qemu_clients_v3

Revision history for this message
David Schwarz (david-schwarz) wrote :

I agree that the machine config rather than job should specify the
client type--particularly because it's entirely possible in our testing
that we may have a mix of different client types in a single
multi-target test job.

I was thinking of splitting the board and machine configs into separate
groups of files to help cut down duplication of common settings.
Machine config (currently in config/hosts in this branch) would include
any machine-specific configuration, including its board type:

panda01.conf:

[machine]
client_type = ssh
hostname = panda01
# References a board-specific config file
board_type = PandaBoard
ip_addr = 192.168.1.1
username = test1
password = test1
has_feature_x = yes

...then the board configuration file could include the information
common to all machines of a particular type, currently being stored in
the config.py Board classes:

PandaBoard.conf

[board]
uboot_cmds = yadda yadda
boot_part = 1
test_part = 2

David

« Back to merge proposal