Merge lp:~dave-martin-arm/linaro-image-tools/support-uncompressed-binary-tarball into lp:linaro-image-tools/11.11

[Dave Martin]

[James Westby (james-w)]

On Tue, 31 Aug 2010 13:50:54 -0000, Dave Martin <email address hidden> wrote:
> Dave Martin has proposed merging lp:~dave-martin-arm/linaro-image-tools/support-uncompressed-binary-tarball into lp:linaro-image-tools.
>
> Requested reviews:
> Linaro Maintainers (linaro-maintainers)
> Related bugs:
> #627393 linaro-media-create fails silently if the argument to --binary is an uncompressed tarball
> https://bugs.launchpad.net/bugs/627393
>
> --
> https://code.launchpad.net/~dave-martin-arm/linaro-image-tools/support-uncompressed-binary-tarball/+merge/34199
> Your team Linaro Maintainers is requested to review the proposed merge of lp:~dave-martin-arm/linaro-image-tools/support-uncompressed-binary-tarball into lp:linaro-image-tools.
> === modified file 'linaro-media-create'
> --- linaro-media-create 2010-08-29 19:29:48 +0000
> +++ linaro-media-create 2010-08-31 13:50:53 +0000
> @@ -86,6 +86,7 @@
> *.gz) sudo tar -x --gzip -f $BINARY_TARBALL binary/${parts_dir};;
> *.lzma) lzcat $BINARY_TARBALL | sudo tar -x -f - binary/${parts_dir};;
> *.xz) xzcat $BINARY_TARBALL | sudo tar -x -f - binary/${parts_dir};;
> + *.tar) sudo tar -x -f $BINARY_TARBALL binary/${parts_dir};;
> *) false;;
> esac

Should the catch-all case be changed to error out to prevent things like
this happening in the future?

Thanks,

James

[Loïc Minier (lool)]

I fixed all tar calls in r38 now; we don't use any case statement anymore, but just rely on tar's ability to detect the compression type based on the extension.

Unmerged revisions

35. By Dave Martin on 2010-08-31

Add support to cope with uncompressed --binary <tarball>.tar

=== modified file 'linaro-media-create'
--- linaro-media-create	2010-08-29 19:29:48 +0000
+++ linaro-media-create	2010-08-31 13:50:53 +0000
@@ -86,6 +86,7 @@
     *.gz)   sudo tar -x --gzip  -f $BINARY_TARBALL binary/${parts_dir};;
     *.lzma) lzcat $BINARY_TARBALL | sudo tar -x -f - binary/${parts_dir};;
     *.xz)   xzcat $BINARY_TARBALL | sudo tar -x -f - binary/${parts_dir};;
+    *.tar)  sudo tar -x -f $BINARY_TARBALL binary/${parts_dir};;
     *)      false;;
   esac