Linaro Image Tools

Code review comment for lp:~dave-martin-arm/linaro-image-tools/miscellaneous-fixes

Revision history for this message

James Westby (james-w) wrote on 2010-10-08:

106 + sudo cp "$LINARO_HWPACK_INSTALL" ${chroot}/usr/bin

Might as well quote the second argument too.

121 + sudo rm -f ${chroot}/"$(basename "$HWPACK_FILE")"

I would prefer "${chroot}/$(basename "$HWPACK_FILE")"

I haven't reviewed the functional changes.

Thanks,

James

review: Approve (quoting)