Code review comment for lp:~dave-cheney/juju-core/182-fix-lp-1322018

Revision history for this message
Dave Cheney (dave-cheney) wrote :

Reviewers: mp+220565_code.launchpad.net,

Message:
Please take a look.

Description:
provider/maas: fix lp 1322018

https://code.launchpad.net/~dave-cheney/juju-core/182-fix-lp-1322018/+merge/220565

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/94710045/

Affected files (+4, -2 lines):
   A [revision details]
   M provider/maas/environ_whitebox_test.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20140522050027-49ughajngzek0zl5
+New revision: <email address hidden>

Index: provider/maas/environ_whitebox_test.go
=== modified file 'provider/maas/environ_whitebox_test.go'
--- provider/maas/environ_whitebox_test.go 2014-05-19 08:16:18 +0000
+++ provider/maas/environ_whitebox_test.go 2014-05-22 05:34:00 +0000
@@ -603,7 +603,7 @@
   env := suite.makeEnviron()
   a, err := env.SupportedArchitectures()
   c.Assert(err, gc.IsNil)
- c.Assert(a, gc.DeepEquals, []string{"amd64"})
+ c.Assert(a, jc.SameContents, []string{"amd64"})
  }

  func (suite *environSuite) TestConstraintsValidator(c *gc.C) {
@@ -614,7 +614,7 @@
   cons := constraints.MustParse("arch=amd64 cpu-power=10 instance-type=foo")
   unsupported, err := validator.Validate(cons)
   c.Assert(err, gc.IsNil)
- c.Assert(unsupported, gc.DeepEquals,
[]string{"cpu-power", "instance-type"})
+ c.Assert(unsupported, jc.SameContents,
[]string{"cpu-power", "instance-type"})
  }

  func (suite *environSuite) TestConstraintsValidatorVocab(c *gc.C) {

« Back to merge proposal