Merge lp:~dave-cheney/juju-core/128-environs-sync-tempdir-prefix into lp:~go-bot/juju-core/trunk

[Dave Cheney]

environs/sync: use a tempdir prefix

environs/sync tests create half a dozen copies of temporary tools in /tmp. This change gives them a known prefix so it is possible to clean them up later.

environs/sync: use a tempdir prefix

environs/sync tests create half a dozen copies of temporary tools in /tmp. This change gives them a known prefix so it is possible to clean them up later.

https://codereview.appspot.com/86370045/

[Dave Cheney (dave-cheney)]

Reviewers: mp+215087_code.launchpad.net,

Message:
Please take a look.

Description:
environs/sync: use a tempdir prefix

environs/sync tests create half a dozen copies of temporary tools in
/tmp. This change gives them a known prefix so it is possible to clean
them up later.

https://code.launchpad.net/~dave-cheney/juju-core/128-environs-sync-tempdir-prefix/+merge/215087

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/86370045/

Affected files (+3, -1 lines):
   A [revision details]
   M environs/sync/sync.go

Index: [revision details]
=== added file '[revision details]'
--- [revision details] 2012-01-01 00:00:00 +0000
+++ [revision details] 2012-01-01 00:00:00 +0000
@@ -0,0 +1,2 @@
+Old revision: tarmac-20140410053917-gc4krsf99t41zy4c
+New revision: <email address hidden>

Index: environs/sync/sync.go
=== modified file 'environs/sync/sync.go'
--- environs/sync/sync.go 2014-03-21 03:27:16 +0000
+++ environs/sync/sync.go 2014-04-10 06:53:27 +0000
@@ -293,7 +293,7 @@
   }
   size := fileInfo.Size()
   logger.Infof("built tools %v (%dkB)", toolsVersion, (size+512)/1024)
- baseToolsDir, err := ioutil.TempDir("", "")
+ baseToolsDir, err := ioutil.TempDir("", "juju-tools")
   if err != nil {
    return nil, err
   }

[Andrew Wilkins (axwalk)]

On 2014/04/10 06:57:08, dfc wrote:
> Please take a look.

LGTM

https://codereview.appspot.com/86370045/

=== modified file 'environs/sync/sync.go'
--- environs/sync/sync.go	2014-03-21 03:27:16 +0000
+++ environs/sync/sync.go	2014-04-10 06:56:52 +0000
@@ -293,7 +293,7 @@
 	}
 	size := fileInfo.Size()
 	logger.Infof("built tools %v (%dkB)", toolsVersion, (size+512)/1024)
-	baseToolsDir, err := ioutil.TempDir("", "")
+	baseToolsDir, err := ioutil.TempDir("", "juju-tools")
 	if err != nil {
 		return nil, err
 	}