The previous branch updated instance.NewAddress to be varargs and
demonstated that most callers of NewAddresses were used to get a slice
of addresses so they could pass them to unit.SetAddresses. By making
SetAddresses vararg NewAddresses is unneeded. This will be next change.
Affected files (+40, -60 lines):
A [revision details]
M cmd/juju/scp_test.go
M cmd/juju/ssh_test.go
M cmd/juju/status_test.go
M cmd/jujud/machine_test.go
M juju/testing/utils.go
M state/api/deployer/deployer_test.go
M state/api/machiner/machiner_test.go
M state/api/provisioner/provisioner_test.go
M state/apiserver/client/client_test.go
M state/apiserver/client/run_test.go
M state/apiserver/deployer/deployer_test.go
M state/apiserver/uniter/uniter_test.go
M state/machine.go
M state/machine_test.go
M state/megawatcher_internal_test.go
M state/state_test.go
M state/unit_test.go
M worker/instancepoller/machine_test.go
M worker/instancepoller/updater.go
M worker/provisioner/kvm-broker_test.go
M worker/provisioner/lxc-broker_test.go
M worker/provisioner/provisioner_test.go
Reviewers: mp+213393_ code.launchpad. net,
Message:
Please take a look.
Description:
unit.SetAddress now takes a vararg
Update LP#1298770
The previous branch updated instance.NewAddress to be varargs and
demonstated that most callers of NewAddresses were used to get a slice
of addresses so they could pass them to unit.SetAddresses. By making
SetAddresses vararg NewAddresses is unneeded. This will be next change.
https:/ /code.launchpad .net/~dave- cheney/ juju-core/ 108-set- addresses- take-varargs/ +merge/ 213393
(do not edit description out of merge proposal)
Please review this at https:/ /codereview. appspot. com/82390045/
Affected files (+40, -60 lines): scp_test. go ssh_test. go status_ test.go machine_ test.go utils.go deployer/ deployer_ test.go machiner/ machiner_ test.go provisioner/ provisioner_ test.go /client/ client_ test.go /client/ run_test. go /deployer/ deployer_ test.go /uniter/ uniter_ test.go test.go er_internal_ test.go instancepoller/ machine_ test.go instancepoller/ updater. go provisioner/ kvm-broker_ test.go provisioner/ lxc-broker_ test.go provisioner/ provisioner_ test.go
A [revision details]
M cmd/juju/
M cmd/juju/
M cmd/juju/
M cmd/jujud/
M juju/testing/
M state/api/
M state/api/
M state/api/
M state/apiserver
M state/apiserver
M state/apiserver
M state/apiserver
M state/machine.go
M state/machine_
M state/megawatch
M state/state_test.go
M state/unit_test.go
M worker/
M worker/
M worker/
M worker/
M worker/